Re: implicit declaration of datumIsEqual in parse_coerce.c

2020-05-02 Thread Noah Misch
On Tue, Apr 07, 2020 at 10:39:30PM -0400, Tom Lane wrote: > > On Tue, Apr 07, 2020 at 05:16:58PM -0400, Tom Lane wrote: > >> That's inside "#ifdef RANDOMIZE_ALLOCATED_MEMORY", which probably > >> explains why most of us aren't seeing it. My guess is somebody > >> removed an #include without realiz

Re: implicit declaration of datumIsEqual in parse_coerce.c

2020-04-07 Thread Tom Lane
Michael Paquier writes: > On Tue, Apr 07, 2020 at 05:16:58PM -0400, Tom Lane wrote: >> That's inside "#ifdef RANDOMIZE_ALLOCATED_MEMORY", which probably >> explains why most of us aren't seeing it. My guess is somebody >> removed an #include without realizing that this chunk of code >> needed it.

Re: implicit declaration of datumIsEqual in parse_coerce.c

2020-04-07 Thread Michael Paquier
On Tue, Apr 07, 2020 at 05:16:58PM -0400, Tom Lane wrote: > That's inside "#ifdef RANDOMIZE_ALLOCATED_MEMORY", which probably > explains why most of us aren't seeing it. My guess is somebody > removed an #include without realizing that this chunk of code > needed it. [cough] commit: 4dbcb3f844ec

Re: implicit declaration of datumIsEqual in parse_coerce.c

2020-04-07 Thread Tom Lane
Tomas Vondra writes: > Not sure what changed, but I'm seeing this failure: > parse_coerce.c: In function ‘coerce_type’: > parse_coerce.c:345:9: warning: implicit declaration of function > ‘datumIsEqual’ [-Wimplicit-function-declaration] >345 |if (!datumIsEqual(newcon->constvalue, val2, f

implicit declaration of datumIsEqual in parse_coerce.c

2020-04-07 Thread Tomas Vondra
Hi, Not sure what changed, but I'm seeing this failure: parse_coerce.c: In function ‘coerce_type’: parse_coerce.c:345:9: warning: implicit declaration of function ‘datumIsEqual’ [-Wimplicit-function-declaration] 345 |if (!datumIsEqual(newcon->constvalue, val2, false, newcon->constlen))