Re: infobits_set WAL record struct field is int8

2023-04-11 Thread Peter Geoghegan
On Tue, Apr 11, 2023 at 1:48 PM Andres Freund wrote: > Makes sense. Looks like there never was a flag defined for the sign bit, > luckily. I assume you're just going to apply this for HEAD? Yes. I'm also going to rename the TransactionId field to "xmax", for consistency with nearby very similar

Re: infobits_set WAL record struct field is int8

2023-04-11 Thread Andres Freund
Hi, On 2023-04-11 13:13:49 -0700, Peter Geoghegan wrote: > Commit 0ac5ad5134 ("Improve concurrency of foreign key locking") added > infobits_set fields to certain WAL records. However, in the case of > xl_heap_lock, it made the data type int8 rather than uint8. > > I believe that this was a minor

infobits_set WAL record struct field is int8

2023-04-11 Thread Peter Geoghegan
Commit 0ac5ad5134 ("Improve concurrency of foreign key locking") added infobits_set fields to certain WAL records. However, in the case of xl_heap_lock, it made the data type int8 rather than uint8. I believe that this was a minor oversight. Attached patch fixes the issue. -- Peter Geoghegan