Re: installcheck failure in indirect_toast with default_toast_compression = lz4

2021-06-07 Thread Michael Paquier
On Sun, Jun 06, 2021 at 03:52:57PM -0500, Justin Pryzby wrote: > See also a prior discussion: > https://www.postgresql.org/message-id/CAFiTN-sm8Dpx3q92g5ohTdZu1_wKsw96-KiEMf3SoK8DhRPfWw%40mail.gmail.com Ah, thanks for the reference. So this was discussed but not actually fixed. I can see the

Re: installcheck failure in indirect_toast with default_toast_compression = lz4

2021-06-06 Thread Justin Pryzby
On Sat, Jun 05, 2021 at 09:20:43AM +0900, Michael Paquier wrote: > As said in $subject, installcheck fails once I set up a server with > default_toast_compression = lz4 in the test indirect_toast. Please > see the attached for the diffs. > > The issue is that the ordering of the tuples returned

Re: installcheck failure in indirect_toast with default_toast_compression = lz4

2021-06-04 Thread Michael Paquier
On Fri, Jun 04, 2021 at 08:28:59PM -0400, Tom Lane wrote: > Hmm. I'm not very clear on what that test is intending to test, > but maybe it's dependent on pglz compression, in which case the > right fix would be to force default_toast_compression = pglz > for the duration of the test. Support for

Re: installcheck failure in indirect_toast with default_toast_compression = lz4

2021-06-04 Thread Tom Lane
Michael Paquier writes: > The issue is that the ordering of the tuples returned by UPDATE > RETURNING is not completely stable. Perhaps we should just enforce > the order of those tuples by wrapping the DMLs into a CTE and use an > ORDER BY in the outer query. Hmm. I'm not very clear on what

installcheck failure in indirect_toast with default_toast_compression = lz4

2021-06-04 Thread Michael Paquier
Hi all, As said in $subject, installcheck fails once I set up a server with default_toast_compression = lz4 in the test indirect_toast. Please see the attached for the diffs. The issue is that the ordering of the tuples returned by UPDATE RETURNING is not completely stable. Perhaps we should