Re: introduce bufmgr hooks

2022-09-02 Thread Nathan Bossart
On Thu, Sep 01, 2022 at 05:34:03PM -0700, Andres Freund wrote: > On 2022-09-01 13:11:50 -0700, Nathan Bossart wrote: >> On Wed, Aug 31, 2022 at 08:29:31AM -0700, Andres Freund wrote: >> > I also think it'll >> > make it harder to improve things in this area, which needs quite a bit of >> > work. >>

Re: introduce bufmgr hooks

2022-09-01 Thread Andres Freund
Hi, On 2022-09-01 13:11:50 -0700, Nathan Bossart wrote: > On Wed, Aug 31, 2022 at 08:29:31AM -0700, Andres Freund wrote: > > I'm very doubtful this is a good idea. These are quite hot paths. While not > > a > > huge cost, adding an indirection isn't free nonetheless. > > Are you concerned about

Re: introduce bufmgr hooks

2022-09-01 Thread Nathan Bossart
ubject: [PATCH v2 1/1] Introduce bufmgr hooks. These hooks can be used for maintaining a secondary buffer cache outside of the regular shared buffers. In theory, there are many other potential uses. --- src/backend/storage/buffer/bufmgr.c | 35 + src/include/s

Re: introduce bufmgr hooks

2022-09-01 Thread Nathan Bossart
On Wed, Aug 31, 2022 at 08:29:31AM -0700, Andres Freund wrote: > I'm very doubtful this is a good idea. These are quite hot paths. While not a > huge cost, adding an indirection isn't free nonetheless. Are you concerned about the NULL check or the potential hook implementations? I can probably te

Re: introduce bufmgr hooks

2022-08-31 Thread Andres Freund
HHi, On 2022-08-29 15:24:49 -0700, Nathan Bossart wrote: > I'd like to propose some new hooks for the buffer manager. My primary goal > is to allow users to create an additional caching mechanism between the > shared buffers and disk for evicted buffers. I'm very doubtful this is a good idea. Th

Re: introduce bufmgr hooks

2022-08-30 Thread Nathan Bossart
Thanks for taking a look. On Tue, Aug 30, 2022 at 01:02:20PM +0900, Kyotaro Horiguchi wrote: > smgr is an abstract interface originally intended to allow to choose > one implementation among several (though cannot dynamically). Even > though the patch intends to replace specific (but most of all)

Re: introduce bufmgr hooks

2022-08-29 Thread Kyotaro Horiguchi
At Mon, 29 Aug 2022 15:24:49 -0700, Nathan Bossart wrote in > I'd like to propose some new hooks for the buffer manager. My primary goal > is to allow users to create an additional caching mechanism between the ... > The attached patch is a first attempt at introducing these hooks with > accept

introduce bufmgr hooks

2022-08-29 Thread Nathan Bossart
Mon Sep 17 00:00:00 2001 From: Nathan Bossart Date: Thu, 11 Aug 2022 16:24:26 -0700 Subject: [PATCH v1 1/1] Introduce bufmgr hooks. These hooks can be used for maintaining a secondary buffer cache outside of the regular shared buffers. In theory, there are many other potential uses. --- src