In a blog post
(https://about.gitlab.com/blog/2021/09/29/why-we-spent-the-last-month-eliminating-postgresql-subtransactions/),
I described how PostgreSQL can enter into a suboverflow condition on
the replica under a number of conditions:
1. A long transaction starts.
2. A single SAVEPOINT is issu
> On Tue, Oct 12, 2021 at 09:53:22PM -0700, Stan Hu wrote:
>
> I described how PostgreSQL can enter into a suboverflow condition on
> the replica under a number of conditions:
>
> 1. A long transaction starts.
> 2. A single SAVEPOINT is issued.
> 3. Many rows are updated on the primary, and the sam
> 17 окт. 2021 г., в 21:55, Dmitry Dolgov <9erthali...@gmail.com> написал(а):
> I wonder what would be side
> effects of clearing it when the snapshot is not suboverfloved anymore?
I think we should just invalidate lastOverflowedXid on every XLOG_RUNNING_XACTS
if subxid_overflow == false. I ca
> On Wed, Oct 20, 2021 at 04:00:35PM +0500, Andrey Borodin wrote:
> > 17 окт. 2021 г., в 21:55, Dmitry Dolgov <9erthali...@gmail.com> написал(а):
> > I wonder what would be side
> > effects of clearing it when the snapshot is not suboverfloved anymore?
>
> I think we should just invalidate lastOver
On Wed, Oct 20, 2021 at 4:00 AM Andrey Borodin wrote:
>
>
> > 17 окт. 2021 г., в 21:55, Dmitry Dolgov <9erthali...@gmail.com>
> написал(а):
> > I wonder what would be side
> > effects of clearing it when the snapshot is not suboverfloved anymore?
>
> I think we should just invalidate lastOverflow
At Wed, 20 Oct 2021 13:48:33 +0200, Dmitry Dolgov <9erthali...@gmail.com> wrote
in
> > On Wed, Oct 20, 2021 at 04:00:35PM +0500, Andrey Borodin wrote:
> > > 17 окт. 2021 г., в 21:55, Dmitry Dolgov <9erthali...@gmail.com>
> > > написал(а):
> > > I wonder what would be side
> > > effects of cleari
At Wed, 20 Oct 2021 08:55:12 -0700, Stan Hu wrote in
> On Wed, Oct 20, 2021 at 4:00 AM Andrey Borodin wrote:
>
> >
> >
> > > 17 окт. 2021 г., в 21:55, Dmitry Dolgov <9erthali...@gmail.com>
> > написал(а):
> > > I wonder what would be side
> > > effects of clearing it when the snapshot is not su
On Wed, Oct 20, 2021 at 9:01 PM Kyotaro Horiguchi
wrote:
>
> lastOverflowedXid is the smallest subxid that possibly exists but
> possiblly not known to the standby. So if all top-level transactions
> older than lastOverflowedXid end, that means that all the
> subtransactions in doubt are known to
On Thu, Oct 21, 2021 at 07:21 Stan Hu wrote:
> On Wed, Oct 20, 2021 at 9:01 PM Kyotaro Horiguchi
> wrote:
> >
> > lastOverflowedXid is the smallest subxid that possibly exists but
> > possiblly not known to the standby. So if all top-level transactions
> > older than lastOverflowedXid end, that
On Mon, Oct 25, 2021 at 11:41 AM Nikolay Samokhvalov
wrote:
> On Thu, Oct 21, 2021 at 07:21 Stan Hu wrote:
>
>> On Wed, Oct 20, 2021 at 9:01 PM Kyotaro Horiguchi
>> wrote:
>> >
>> > lastOverflowedXid is the smallest subxid that possibly exists but
>> > possiblly not known to the standby. So if
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, failed
Spec compliant: not tested
Documentation:not tested
The fix is trivial and works as expected, solving the problem
Tested
On Mon, Nov 1, 2021 at 11:55 PM Nikolay Samokhvalov
wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, failed
Please ignore this – I didn't understand the UI.
> 21 окт. 2021 г., в 09:01, Kyotaro Horiguchi
> написал(а):
>
> If the discussion so far is correct, the following diff will fix the
> issue.
>
> diff --git a/src/backend/storage/ipc/procarray.c
> b/src/backend/storage/ipc/procarray.c
> index bd3c7a47fe..19682b73ec 100644
> --- a/src/backen
( a.On Wed, Nov 3, 2021 at 11:44 AM Andrey Borodin wrote:
> > 21 окт. 2021 г., в 09:01, Kyotaro Horiguchi
> > написал(а):
> >
> > If the discussion so far is correct, the following diff will fix the
> > issue.
> >
> > diff --git a/src/backend/storage/ipc/procarray.c
> > b/src/backend/storage/ip
> 3 нояб. 2021 г., в 14:08, Alexander Korotkov
> написал(а):
>
> ( a.On Wed, Nov 3, 2021 at 11:44 AM Andrey Borodin
> wrote:
>>> 21 окт. 2021 г., в 09:01, Kyotaro Horiguchi
>>> написал(а):
>>>
>>> If the discussion so far is correct, the following diff will fix the
>>> issue.
>>>
>>> di
On Thu, 21 Oct 2021 at 05:01, Kyotaro Horiguchi wrote:
>
> At Wed, 20 Oct 2021 08:55:12 -0700, Stan Hu wrote in
> > On Wed, Oct 20, 2021 at 4:00 AM Andrey Borodin wrote:
> >
> > >
> > >
> > > > 17 окт. 2021 г., в 21:55, Dmitry Dolgov <9erthali...@gmail.com>
> > > написал(а):
> > > > I wonder wha
Hi!
On Wed, Nov 3, 2021 at 8:51 PM Simon Riggs wrote:
> It is however, an undocumented modularity violation. I think that is
> acceptable because of the ProcArrayLock traffic, but needs to have a
> comment to explain this at the call to
> ExpireOldKnownAssignedTransactionIds() i.e. " and potentia
Good catch on doing this in ExpireAllKnownAssignedTransactionIds() as well.
Thanks. Looks good to me!
As Nikolay mentioned, I think this is an important bug that we are seeing
in production and would appreciate a backport to v12 if possible.
On Wed, Nov 3, 2021 at 3:07 PM Alexander Korotkov
wrot
On Wed, 3 Nov 2021 at 22:07, Alexander Korotkov wrote:
>
> Hi!
>
> On Wed, Nov 3, 2021 at 8:51 PM Simon Riggs
> wrote:
> > It is however, an undocumented modularity violation. I think that is
> > acceptable because of the ProcArrayLock traffic, but needs to have a
> > comment to explain this at
At Thu, 4 Nov 2021 01:07:05 +0300, Alexander Korotkov
wrote in
> Hi!
>
> On Wed, Nov 3, 2021 at 8:51 PM Simon Riggs
> wrote:
> > It is however, an undocumented modularity violation. I think that is
> > acceptable because of the ProcArrayLock traffic, but needs to have a
> > comment to explain
Hi!
On Fri, Nov 5, 2021 at 10:31 AM Kyotaro Horiguchi
wrote:
> At Thu, 4 Nov 2021 01:07:05 +0300, Alexander Korotkov
> wrote in
> > On Wed, Nov 3, 2021 at 8:51 PM Simon Riggs
> > wrote:
> > > It is however, an undocumented modularity violation. I think that is
> > > acceptable because of the
At Sat, 6 Nov 2021 19:16:09 +0300, Alexander Korotkov
wrote in
> Pushed!
Thanks!
--
Kyotaro Horiguchi
NTT Open Source Software Center
22 matches
Mail list logo
