On 2022-Jul-26, Alvaro Herrera wrote:
> With this version I keep the target name as -recurse, and at least the
> ecpg<->libpq problem is no more AFAICT.
... but I think we're missing some more dependencies, because if I
remove everything (beyond make clean), then a "make -j8 world-bin"
fails,
Hi,
On 2022-07-22 19:50:02 -0400, Tom Lane wrote:
> I wrote:
> > So it'll work in 3.81 (released 2006) and later, but not 3.80.
>
> Confirmed that things are fine with 3.81.
Thanks for looking into this Alvaro, Andrew, Justin, Tom - I was on
vacation...
Greetings,
Andres Freund
Ah, I found what the actual problem is: we have sprinkled a few
dependencies on "...-recurse" throught the tree, but the patch I posted
yesterday changes the manufactured target as "-recursive", as it was
prior to 1bd201214965; so essentially these manually added dependencies
all became silent
On 2022-Jul-25, Alvaro Herrera wrote:
> Anyway, I tried a revert of 1bd201214965 -- I ended up with the
> attached.
--
Álvaro HerreraBreisgau, Deutschland — https://www.EnterpriseDB.com/
>From 387835c04436bc59b9c82e32d9259c74d68ceabf Mon Sep 17 00:00:00 2001
From: Alvaro Herrera
On 2022-Jul-22, Tom Lane wrote:
> Barring objections, I'll push the attached patch. I suppose we
> could undo whatever dumbing-down was done in _create_recursive_target,
> but is it worth troubling with?
Excellent, many thanks. I tried to get Make 3.80 built here, to no
avail. I have updated
I wrote:
> So it'll work in 3.81 (released 2006) and later, but not 3.80.
Confirmed that things are fine with 3.81.
> TBH my inclination here is to move our goalposts to say "we support
> gmake 3.81 and later".
Barring objections, I'll push the attached patch. I suppose we
could undo whatever
I wrote:
> Yeah, it is. I looked at the gmake manual on that machine, and its
> description of "export" seems about the same as what I see in a
> modern version.
Um ... I was not looking in the right place. The description of
"target-specific variables" does not say you can use "export",
Alvaro Herrera writes:
> On 2022-Jul-22, Alvaro Herrera wrote:
>> It's not very common -- we do have some target-specific variable
>> assignments, but none of them use 'export'. I saw somewhere that this
>> works from Make 3.77 onwards, and we require 3.80, so it should be okay.
>> The buildfarm
On 2022-Jul-22, Alvaro Herrera wrote:
> It's not very common -- we do have some target-specific variable
> assignments, but none of them use 'export'. I saw somewhere that this
> works from Make 3.77 onwards, and we require 3.80, so it should be okay.
> The buildfarm will tell us ...
Hm, so
On 2022-Jul-21, Andrew Dunstan wrote:
> On 2022-07-21 Th 04:53, Alvaro Herrera wrote:
> > Here's a different take. Just assign the variable separately.
>
> Nice, I didn't know you could do that.
It's not very common -- we do have some target-specific variable
assignments, but none of them use
On 2022-07-21 Th 04:53, Alvaro Herrera wrote:
> On 2022-Jul-20, Andrew Dunstan wrote:
>
>> On 2022-07-20 We 13:23, Justin Pryzby wrote:
>>> PATH=... && @echo "TAP tests not enabled. Try configuring with
>>> --enable-tap-tests"
>>> /bin/sh: 1: @echo: not found
>>>
>>> make is telling the shell
On 2022-Jul-20, Andrew Dunstan wrote:
> On 2022-07-20 We 13:23, Justin Pryzby wrote:
> > PATH=... && @echo "TAP tests not enabled. Try configuring with
> > --enable-tap-tests"
> > /bin/sh: 1: @echo: not found
> >
> > make is telling the shell to run "@echo" , rather than running "echo"
> >
On 2022-07-20 We 13:23, Justin Pryzby wrote:
> make -C ./src/interfaces/libpq check
> PATH=... && @echo "TAP tests not enabled. Try configuring with
> --enable-tap-tests"
> /bin/sh: 1: @echo: not found
>
> make is telling the shell to run "@echo" , rather than running "echo"
> silently.
>
>
make -C ./src/interfaces/libpq check
PATH=... && @echo "TAP tests not enabled. Try configuring with
--enable-tap-tests"
/bin/sh: 1: @echo: not found
make is telling the shell to run "@echo" , rather than running "echo" silently.
Since:
commit 6b04abdfc5e0653542ac5d586e639185a8c61a39
Author:
14 matches
Mail list logo
