Re: make_ctags: use -I option to ignore pg_node_attr macro

2023-06-13 Thread Masahiko Sawada
On Wed, Jun 14, 2023 at 11:16 AM Tatsuo Ishii wrote: > > > Hi Sawada-san, > > > >> In my Mac environment where non-Exuberant ctags and emacs 28.2 are > >> installed, the generated etags file cannot be loaded by emacs due to > >> file format error. The generated TAGS file is: > >> > >> % head -10

Re: make_ctags: use -I option to ignore pg_node_attr macro

2023-06-13 Thread Tatsuo Ishii
> Hi Sawada-san, > >> In my Mac environment where non-Exuberant ctags and emacs 28.2 are >> installed, the generated etags file cannot be loaded by emacs due to >> file format error. The generated TAGS file is: >> >> % head -10 TAGS >> >> ) / >>

Re: make_ctags: use -I option to ignore pg_node_attr macro

2023-06-11 Thread Tatsuo Ishii
Hi Sawada-san, > In my Mac environment where non-Exuberant ctags and emacs 28.2 are > installed, the generated etags file cannot be loaded by emacs due to > file format error. The generated TAGS file is: > > % head -10 TAGS > > ) / >

Re: make_ctags: use -I option to ignore pg_node_attr macro

2023-05-29 Thread Masahiko Sawada
Hi, On Tue, Feb 14, 2023 at 8:15 PM Tatsuo Ishii wrote: > > >> I fixed the above issues and refactored the code. > >> Attached is the updated version of the patch. Thought? > > > > Thank you! Looks good to me. > > Fix pushed. Thank you! In my Mac environment where non-Exuberant ctags and emacs

Re: make_ctags: use -I option to ignore pg_node_attr macro

2023-02-14 Thread Tatsuo Ishii
>> I fixed the above issues and refactored the code. >> Attached is the updated version of the patch. Thought? > > Thank you! Looks good to me. Fix pushed. Thank you! Best reagards, -- Tatsuo Ishii SRA OSS LLC English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp

Re: make_ctags: use -I option to ignore pg_node_attr macro

2023-02-09 Thread Tatsuo Ishii
>> Oops. Thank you for pointing it out. BTW, just out of curiosity, do >> you have etags on you Mac? > > Yes. > > $ etags --version > etags (GNU Emacs 28.2) > Copyright (C) 2022 Free Software Foundation, Inc. > This program is distributed under the terms in ETAGS.README Ok. Probably that was

Re: make_ctags: use -I option to ignore pg_node_attr macro

2023-02-08 Thread Fujii Masao
On 2023/02/08 20:17, Tatsuo Ishii wrote: Attached is the v2 patch. Thanks for the patch! With the patch, I got the following error when executing make_etags.. $ ./src/tools/make_etags etags: invalid option -- 'e' Try 'etags --help' for a complete list of options. sort: No such file

Re: make_ctags: use -I option to ignore pg_node_attr macro

2023-02-08 Thread Tatsuo Ishii
>> Attached is the v2 patch. > > Thanks for the patch! > > With the patch, I got the following error when executing make_etags.. > > $ ./src/tools/make_etags > etags: invalid option -- 'e' > Try 'etags --help' for a complete list of options. > sort: No such file or directory Oops. Thank

Re: make_ctags: use -I option to ignore pg_node_attr macro

2023-02-08 Thread Fujii Masao
On 2023/02/08 9:49, Tatsuo Ishii wrote: I am not sure if this is good way to check if ctags supports "-e" or not. + thenctags --version 2>&1 | grep -- -e >/dev/null Perhaps, "--help" might be intended rather than "--version" to check supported options? Yeah, that was my mistake.

Re: make_ctags: use -I option to ignore pg_node_attr macro

2023-02-07 Thread Tatsuo Ishii
>> I am not sure if this is good way to check if ctags supports "-e" or not. >> >> +thenctags --version 2>&1 | grep -- -e >/dev/null >> >> Perhaps, "--help" might be intended rather than "--version" to check >> supported options? > > Yeah, that was my mistake. > >> Even so, ctags

Re: make_ctags: use -I option to ignore pg_node_attr macro

2023-02-07 Thread Tatsuo Ishii
>> The patch drops support for "-n" option :-< >> >> Attached is the patch by fixing make_ctags (make_etags is not >> touched). >> >> If Exuberant-type ctags is available, use it (not changed). >> If Exuberant-type ctags is not available, try old ctags (not changed). >> If the old ctags

Re: make_ctags: use -I option to ignore pg_node_attr macro

2023-02-07 Thread Yugo NAGATA
On Tue, 07 Feb 2023 21:29:04 +0900 (JST) Tatsuo Ishii wrote: > > Does is make sense to change make_etags as the attached patch does? > > This allows make_etags to use etags if Exuberant-type ctags is not > > available. This allows users to use make_etags if hey has either > > Exuberant-type

Re: make_ctags: use -I option to ignore pg_node_attr macro

2023-02-07 Thread Tatsuo Ishii
> Does is make sense to change make_etags as the attached patch does? > This allows make_etags to use etags if Exuberant-type ctags is not > available. This allows users to use make_etags if hey has either > Exuberant-type ctags or etags. The patch drops support for "-n" option :-< Attached is

Re: make_ctags: use -I option to ignore pg_node_attr macro

2023-02-07 Thread Yugo NAGATA
On Tue, 07 Feb 2023 17:19:37 +0900 (JST) Tatsuo Ishii wrote: > >> Since this commit, make_etags has started failing to generate > >> tags files with the following error messages, on my MacOS. > >> > >> $ src/tools/make_etags > >>

Re: make_ctags: use -I option to ignore pg_node_attr macro

2023-02-07 Thread Tatsuo Ishii
>> Since this commit, make_etags has started failing to generate >> tags files with the following error messages, on my MacOS. >> >> $ src/tools/make_etags >> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ctags: >> illegal option -- e >> usage: ctags

Re: make_ctags: use -I option to ignore pg_node_attr macro

2023-02-06 Thread Tatsuo Ishii
> On 2022/10/19 13:25, Tatsuo Ishii wrote: >> Thanks. the v6 patch pushed to master branch. > > Since this commit, make_etags has started failing to generate > tags files with the following error messages, on my MacOS. > > $ src/tools/make_etags >

Re: make_ctags: use -I option to ignore pg_node_attr macro

2023-02-06 Thread Fujii Masao
On 2022/10/19 13:25, Tatsuo Ishii wrote: Thanks. the v6 patch pushed to master branch. Since this commit, make_etags has started failing to generate tags files with the following error messages, on my MacOS. $ src/tools/make_etags

Re: make_ctags: use -I option to ignore pg_node_attr macro

2022-10-19 Thread Yugo NAGATA
On Wed, 19 Oct 2022 18:11:13 +0900 (JST) Tatsuo Ishii wrote: > > By the way, after executing both make_etags and make_ctags, trying tag jump > > in my vim causes the following error even though there are correct tags > > files. > > > > E431: Format error in tags file

Re: make_ctags: use -I option to ignore pg_node_attr macro

2022-10-19 Thread Tatsuo Ishii
> By the way, after executing both make_etags and make_ctags, trying tag jump > in my vim causes the following error even though there are correct tags files. > > E431: Format error in tags file "backend/access/heap/TAGS" > > Removing all TAGS files as below can resolve this error. > $ find .

Re: make_ctags: use -I option to ignore pg_node_attr macro

2022-10-19 Thread Yugo NAGATA
On Wed, 19 Oct 2022 17:17:17 +0900 (JST) Tatsuo Ishii wrote: > >> > By the way, in passing, how about adding "tags" and "TAGS" to > >> > .gitignore file? > >> > >> Sounds like a good idea. > > > > Ok, the patch is attached. > > I have search the mail archive and found this: > >

Re: make_ctags: use -I option to ignore pg_node_attr macro

2022-10-19 Thread Tatsuo Ishii
>> > By the way, in passing, how about adding "tags" and "TAGS" to >> > .gitignore file? >> >> Sounds like a good idea. > > Ok, the patch is attached. I have search the mail archive and found this:

Re: make_ctags: use -I option to ignore pg_node_attr macro

2022-10-18 Thread Yugo NAGATA
On Wed, 19 Oct 2022 13:25:17 +0900 (JST) Tatsuo Ishii wrote: > > Hi, > > > > On Sat, 15 Oct 2022 10:40:29 +0900 (JST) > > Tatsuo Ishii wrote: > > > >> > On Thu, 13 Oct 2022 15:35:09 +0900 (JST) > >> > Tatsuo Ishii wrote: > >> > > >> >> > OK, that sounds good then. I would make a feature

Re: make_ctags: use -I option to ignore pg_node_attr macro

2022-10-18 Thread Tatsuo Ishii
> Hi, > > On Sat, 15 Oct 2022 10:40:29 +0900 (JST) > Tatsuo Ishii wrote: > >> > On Thu, 13 Oct 2022 15:35:09 +0900 (JST) >> > Tatsuo Ishii wrote: >> > >> >> > OK, that sounds good then. I would make a feature request to have a >> >> > switch that supresses creation of these links, then. >>

Re: make_ctags: use -I option to ignore pg_node_attr macro

2022-10-18 Thread Yugo NAGATA
Hi, On Sat, 15 Oct 2022 10:40:29 +0900 (JST) Tatsuo Ishii wrote: > > On Thu, 13 Oct 2022 15:35:09 +0900 (JST) > > Tatsuo Ishii wrote: > > > >> > OK, that sounds good then. I would make a feature request to have a > >> > switch that supresses creation of these links, then. > >> > >> Ok, I

Re: make_ctags: use -I option to ignore pg_node_attr macro

2022-10-14 Thread Tatsuo Ishii
> On Thu, 13 Oct 2022 15:35:09 +0900 (JST) > Tatsuo Ishii wrote: > >> > OK, that sounds good then. I would make a feature request to have a >> > switch that supresses creation of these links, then. >> >> Ok, I have added "-n" option to make_ctags so that it skips to create >> the links. >> >>

Re: make_ctags: use -I option to ignore pg_node_attr macro

2022-10-13 Thread Yugo NAGATA
On Thu, 13 Oct 2022 15:35:09 +0900 (JST) Tatsuo Ishii wrote: > > OK, that sounds good then. I would make a feature request to have a > > switch that supresses creation of these links, then. > > Ok, I have added "-n" option to make_ctags so that it skips to create > the links. > > Also I have

Re: make_ctags: use -I option to ignore pg_node_attr macro

2022-10-13 Thread Tatsuo Ishii
> OK, that sounds good then. I would make a feature request to have a > switch that supresses creation of these links, then. Ok, I have added "-n" option to make_ctags so that it skips to create the links. Also I have changed make_etags so that it exec make_ctags, which seems to be the

Re: make_ctags: use -I option to ignore pg_node_attr macro

2022-10-12 Thread Peter Eisentraut
On 10.10.22 12:04, Alvaro Herrera wrote: In my own tags script I just call "ctags -R", and I feed cscope with these find lines (find $SRCDIR \( -name tmp_install -prune -o -name tmp_check -prune \) -o \( -name "*.[chly]" -o -iname "*makefile*" -o -name "*.mk" -o -name "*.in" -o -name "*.sh" -o

Re: make_ctags: use -I option to ignore pg_node_attr macro

2022-10-12 Thread Bruce Momjian
On Wed, Oct 12, 2022 at 10:26:03PM +0900, Tatsuo Ishii wrote: > > However ... hmm ... > > > >> find . \( -name 'CVS' -prune \) -o \( -name .git -prune \) -o -type d > >> -print | > >> while read DIR > >> -do[ "$DIR" != "." ] && ln -f -s `echo "$DIR" | sed > >> 's;/[^/]*;/..;g'`/tags

Re: make_ctags: use -I option to ignore pg_node_attr macro

2022-10-12 Thread Alvaro Herrera
On 2022-Oct-12, Tatsuo Ishii wrote: > >> find . \( -name 'CVS' -prune \) -o \( -name .git -prune \) -o -type d > >> -print | > >> while read DIR > >> -do[ "$DIR" != "." ] && ln -f -s `echo "$DIR" | sed > >> 's;/[^/]*;/..;g'`/tags "$DIR"/tags > >> +do[ "$DIR" != "." ] && ln -f

Re: make_ctags: use -I option to ignore pg_node_attr macro

2022-10-12 Thread Alvaro Herrera
On 2022-Oct-12, Tom Lane wrote: > Tatsuo Ishii writes: > >> If we're going to do this, then I suggest that make_etags should become > >> a symlink to make_ctags, and behave as if -e is given when called under > >> that name. > > > What I had in my mind was making make_etags a script just exec >

Re: make_ctags: use -I option to ignore pg_node_attr macro

2022-10-12 Thread Julien Rouhaud
On Wed, Oct 12, 2022 at 10:09:06AM -0400, Tom Lane wrote: > > I don't think it's possible to store a symlink in git, so > having one file exec the other sounds saner to me too. Git handles symlink just fine, but those will obviously create extra burden for Windows users (git will just create a

Re: make_ctags: use -I option to ignore pg_node_attr macro

2022-10-12 Thread Tom Lane
Tatsuo Ishii writes: >> If we're going to do this, then I suggest that make_etags should become >> a symlink to make_ctags, and behave as if -e is given when called under >> that name. > What I had in my mind was making make_etags a script just exec > make_ctags (with -e option). But I don't

Re: make_ctags: use -I option to ignore pg_node_attr macro

2022-10-12 Thread Tatsuo Ishii
>> I tried to apply the v2 patch approach to make_etags but noticed that >> make_ctags and make_etags have quite a few duplicate codes, that would >> bring maintenance headache. I think we could merge make_etags into >> make_ctags, then add "-e" option (or whatever) to make_ctags so that >> it

Re: make_ctags: use -I option to ignore pg_node_attr macro

2022-10-12 Thread Alvaro Herrera
On 2022-Oct-12, Tatsuo Ishii wrote: > I tried to apply the v2 patch approach to make_etags but noticed that > make_ctags and make_etags have quite a few duplicate codes, that would > bring maintenance headache. I think we could merge make_etags into > make_ctags, then add "-e" option (or

Re: make_ctags: use -I option to ignore pg_node_attr macro

2022-10-12 Thread Tatsuo Ishii
Hi, >> > I found that tag files generated by src/tools/make_ctags >> > doesn't include some keywords, that were field names of node >> > structs, for example norm_select in RestrictInfo. Such fields >> > are defined with pg_node_attr macro that was introduced >> > recently, like: >> > >> >

Re: make_ctags: use -I option to ignore pg_node_attr macro

2022-10-12 Thread Yugo NAGATA
Hello On Mon, 10 Oct 2022 12:04:22 +0200 Alvaro Herrera wrote: > Hello > > On 2022-Oct-07, Yugo NAGATA wrote: > > > I found that tag files generated by src/tools/make_ctags > > doesn't include some keywords, that were field names of node > > structs, for example norm_select in RestrictInfo.

Re: make_ctags: use -I option to ignore pg_node_attr macro

2022-10-10 Thread Alvaro Herrera
Hello On 2022-Oct-07, Yugo NAGATA wrote: > I found that tag files generated by src/tools/make_ctags > doesn't include some keywords, that were field names of node > structs, for example norm_select in RestrictInfo. Such fields > are defined with pg_node_attr macro that was introduced > recently,

make_ctags: use -I option to ignore pg_node_attr macro

2022-10-07 Thread Yugo NAGATA
Hi, I found that tag files generated by src/tools/make_ctags doesn't include some keywords, that were field names of node structs, for example norm_select in RestrictInfo. Such fields are defined with pg_node_attr macro that was introduced recently, like: Selectivity norm_selec