On 2023-03-08 We 08:49, Nazir Bilal Yavuz wrote:
Hi,
On Mon, 6 Mar 2023 at 18:30, Andrew Dunstan wrote:
There are two separate issues here, but let's deal with the Windows issue.
Attached is the log output and also a listing of the runpython directory in the
build directory.
Thanks for the
Hi,
On Mon, 6 Mar 2023 at 18:30, Andrew Dunstan wrote:
> There are two separate issues here, but let's deal with the Windows issue.
> Attached is the log output and also a listing of the runpython directory in
> the build directory.
Thanks for the logs but I couldn't understand the problem. Is
Hi,
On Fri, 3 Mar 2023 at 22:43, Andrew Dunstan wrote:
> These changes have broken the buildfarm adaptation work in different ways on
> different platforms.
>
> On Windows (but not Linux), the install_test_files are apparently getting
> installed under runpython in the build directory rather th
On 2023-03-03 Fr 01:47, Peter Eisentraut wrote:
On 02.03.23 08:09, Nazir Bilal Yavuz wrote:
On Wed, 1 Mar 2023 at 22:21, Peter Eisentraut
wrote:
Looks good to me. I did a small pass over it to adjust some namings.
For example, I renamed test_install_files to test_install_data, so it's
consi
On 02.03.23 08:09, Nazir Bilal Yavuz wrote:
On Wed, 1 Mar 2023 at 22:21, Peter Eisentraut
wrote:
Looks good to me. I did a small pass over it to adjust some namings.
For example, I renamed test_install_files to test_install_data, so it's
consistent with the overall meson naming:
-install_dat
Hi,
On Wed, 1 Mar 2023 at 22:21, Peter Eisentraut
wrote:
>
> Looks good to me. I did a small pass over it to adjust some namings.
> For example, I renamed test_install_files to test_install_data, so it's
> consistent with the overall meson naming:
>
> -install_data(
> +test_install_data += files
On 23.02.23 19:06, Nazir Bilal Yavuz wrote:
Hi,
Thanks for the review.
On Mon, 20 Feb 2023 at 21:44, Peter Eisentraut
wrote:
I tested this a bit. It works fine. The approach makes sense to me.
The install_additional_files script could be simplified a bit. You
could use os.makedirs(dest,
Hi,
On 2023-02-22 10:09:10 +0100, Peter Eisentraut wrote:
> On 20.02.23 20:48, Andres Freund wrote:
> > On 2023-02-20 19:43:56 +0100, Peter Eisentraut wrote:
> > > I don't think any callers try to copy a directory source, so the
> > > shutil.copytree() stuff isn't necessary.
> >
> > I'd like to u
Hi,
Thanks for the review.
On Mon, 20 Feb 2023 at 21:44, Peter Eisentraut
wrote:
>
> I tested this a bit. It works fine. The approach makes sense to me.
>
> The install_additional_files script could be simplified a bit. You
> could use os.makedirs(dest, exist_ok=True) and avoid the error chec
On 20.02.23 20:48, Andres Freund wrote:
On 2023-02-20 19:43:56 +0100, Peter Eisentraut wrote:
I don't think any callers try to copy a directory source, so the
shutil.copytree() stuff isn't necessary.
I'd like to use it for installing docs outside of the normal install
target. Of course we coul
On 2023-02-20 19:43:56 +0100, Peter Eisentraut wrote:
> I don't think any callers try to copy a directory source, so the
> shutil.copytree() stuff isn't necessary.
I'd like to use it for installing docs outside of the normal install
target. Of course we could add the ability at a later point, but
On 09.02.23 16:30, Nazir Bilal Yavuz wrote:
On 2/8/23 13:30, Peter Eisentraut wrote:
If you feel that your patch is ready, please add it to the commit
fest. I look forward to reviewing it.
Thanks! Commit fest entry link: https://commitfest.postgresql.org/42/4173/
I tested this a bit. It
Hi,
On 2/8/23 13:30, Peter Eisentraut wrote:
If you feel that your patch is ready, please add it to the commit
fest. I look forward to reviewing it.
Thanks! Commit fest entry link: https://commitfest.postgresql.org/42/4173/
Regards,
Nazir Bilal Yavuz
Microsoft
On 01.02.23 13:41, Nazir Bilal Yavuz wrote:
On 1/31/23 11:44, Peter Eisentraut wrote:
On 30.01.23 18:42, Andres Freund wrote:
Bilal, with a bit of help by me, worked on an alternative approach to
this. It's a lot more verbose in the initial change, but wouldn't
increase the
amount of work/lin
Hi,
On 1/31/23 11:44, Peter Eisentraut wrote:
On 30.01.23 18:42, Andres Freund wrote:
Bilal, with a bit of help by me, worked on an alternative approach to
this. It's a lot more verbose in the initial change, but wouldn't
increase the
amount of work/lines for new test modules. The main advant
On 30.01.23 18:42, Andres Freund wrote:
On 2023-01-30 08:37:42 +0100, Peter Eisentraut wrote:
One open issue (IMO) with the meson build system is that it installs the
test modules under src/test/modules/ as part of a normal installation. This
is because there is no way to set up up the build sys
Hi,
On 2023-01-30 08:37:42 +0100, Peter Eisentraut wrote:
> One open issue (IMO) with the meson build system is that it installs the
> test modules under src/test/modules/ as part of a normal installation. This
> is because there is no way to set up up the build system to install extra
> things on
One open issue (IMO) with the meson build system is that it installs the
test modules under src/test/modules/ as part of a normal installation.
This is because there is no way to set up up the build system to install
extra things only when told. I think we still need a way to disable
this some
18 matches
Mail list logo
