Re: openssl valgrind failures on skink are due to openssl issue

2019-06-18 Thread Michael Paquier
On Tue, Jun 18, 2019 at 07:44:26PM -0700, Andres Freund wrote: > Really, I can do that? Here is some of the stuff I use, just for the reference: ./Configure linux-x86_64 --prefix=$HOME/stable/openssl/1.1.1/ ./config --prefix=$HOME/stable/openssl/1.1.1 shared -- Michael signature.asc Description:

Re: openssl valgrind failures on skink are due to openssl issue

2019-06-18 Thread Andres Freund
On 2019-06-19 11:28:16 +0900, Michael Paquier wrote: > On Tue, Jun 18, 2019 at 04:34:07PM -0700, Andres Freund wrote: > > It's merged to both branches that contain the broken code. Now we need > > to wait for the next set of openssl releases, and then for distros to > > pick that up. Based on the p

Re: openssl valgrind failures on skink are due to openssl issue

2019-06-18 Thread Michael Paquier
On Tue, Jun 18, 2019 at 04:34:07PM -0700, Andres Freund wrote: > It's merged to both branches that contain the broken code. Now we need > to wait for the next set of openssl releases, and then for distros to > pick that up. Based on the past release cadence > https://www.openssl.org/news/openssl-1.

Re: openssl valgrind failures on skink are due to openssl issue

2019-06-18 Thread Andres Freund
Hi, On 2019-06-18 19:25:12 -0400, Tom Lane wrote: > Did you get any sense of how fast the openssl fix is goinng to show up? It's merged to both branches that contain the broken code. Now we need to wait for the next set of openssl releases, and then for distros to pick that up. Based on the past

Re: openssl valgrind failures on skink are due to openssl issue

2019-06-18 Thread Tom Lane
Andres Freund writes: > What we could do is add a suppression like: > { >broken-openssl-accesses-random >Memcheck:Cond >... >fun:pg_strong_random >fun:InitProcessGlobals >fun:PostmasterMain >fun:main > } > (alternatively one suppression for each RAND_status, RAND_poll

Re: openssl valgrind failures on skink are due to openssl issue

2019-06-18 Thread Andres Freund
Hi, On 2019-06-11 14:07:29 -0700, Andres Freund wrote: > On 2019-06-11 16:55:28 -0400, Tom Lane wrote: > > Andres Freund writes: > > > I can't think of a better way to fix skink for now than just disabling > > > openssl for skink, until 1.1.1d is released. > > > > Couldn't you install a local va

Re: openssl valgrind failures on skink are due to openssl issue

2019-06-12 Thread Michael Paquier
On Tue, Jun 11, 2019 at 02:07:29PM -0700, Andres Freund wrote: > On 2019-06-11 16:55:28 -0400, Tom Lane wrote: >> Andres Freund writes: >>> I can't think of a better way to fix skink for now than just disabling >>> openssl for skink, until 1.1.1d is released. Thanks for digging into the details o

Re: openssl valgrind failures on skink are due to openssl issue

2019-06-11 Thread Andres Freund
Hi, On 2019-06-11 16:55:28 -0400, Tom Lane wrote: > Andres Freund writes: > > I can't think of a better way to fix skink for now than just disabling > > openssl for skink, until 1.1.1d is released. > > Couldn't you install a local valgrind exclusion matching this stack trace? Unfortunately no.

Re: openssl valgrind failures on skink are due to openssl issue

2019-06-11 Thread Tom Lane
Andres Freund writes: > For reasons I do not understand the "cosmetic change" was backpatched > into 1.1.1 And the fix for the cosmetic change, made on master at the > end of March, was only backpatched to 1.1.1 *after* the 1.1.1c release > was made in late May. I mean, huh. Bleah. Not that we'

openssl valgrind failures on skink are due to openssl issue

2019-06-11 Thread Andres Freund
Hi, Skink a few days ago started failing [1][2] with errors like: ==2732== Conditional jump or move depends on uninitialised value(s) ==2732==at 0x4C612E3: ??? (in /usr/lib/x86_64-linux-gnu/libcrypto.so.1.1) ==2732==by 0x4C621FA: RAND_DRBG_generate (in /usr/lib/x86_64-linux-gnu/libcrypto