Re: parseCheckAggregates vs. assign_query_collations

2019-01-16 Thread Andrew Gierth
> "Tom" == Tom Lane writes: >> I'll be looking into this in detail later, but right now, cam anyone >> think of any reason why parseCheckAggregates couldn't be moved to >> after assign_query_collations? Tom> I never particularly liked assign_query_collations, as a matter of Tom>

Re: parseCheckAggregates vs. assign_query_collations

2019-01-16 Thread Tom Lane
Andrew Gierth writes: > Looking into a bug report on the -general list about grouping sets, > which turns out to be an issue of collation assignment: if the query has > CASE GROUPING(expr) WHEN 1 ... > then the expression is rejected as not matching the one in the GROUP BY > clause, because

parseCheckAggregates vs. assign_query_collations

2019-01-16 Thread Andrew Gierth
Looking into a bug report on the -general list about grouping sets, which turns out to be an issue of collation assignment: if the query has CASE GROUPING(expr) WHEN 1 ... then the expression is rejected as not matching the one in the GROUP BY clause, because CASE already assigned collations