Re: peripatus build failures....

2018-08-09 Thread Larry Rosenman
It was never put into the build, and I have a PR open to remove the LLD_UNSAFE flag for 10.5 and the rest of today's releases. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229523 -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 214-642-9640 E-Mail

Re: peripatus build failures....

2018-08-09 Thread Alvaro Herrera
On 2018-Jul-09, Larry Rosenman wrote: > On Mon, Jul 09, 2018 at 05:25:50PM -0400, Tom Lane wrote: > > I wrote: > > > I'd been hesitant to back-patch dddfc4cb2 back in April; but now that > > > it's survived some beta testing, I think that doing so seems like the > > > most appropriate way to fix t

Re: peripatus build failures....

2018-07-09 Thread Larry Rosenman
On Mon, Jul 09, 2018 at 05:25:50PM -0400, Tom Lane wrote: > I wrote: > > I'd been hesitant to back-patch dddfc4cb2 back in April; but now that > > it's survived some beta testing, I think that doing so seems like the > > most appropriate way to fix this. > > Done. Hopefully I didn't break anythin

Re: peripatus build failures....

2018-07-09 Thread Tom Lane
I wrote: > I'd been hesitant to back-patch dddfc4cb2 back in April; but now that > it's survived some beta testing, I think that doing so seems like the > most appropriate way to fix this. Done. Hopefully I didn't break anything; a lot of this code has mutated to some extent since 9.3. But I exp

Re: peripatus build failures....

2018-07-07 Thread Tom Lane
I wrote: > Huh. So what that suggests is that the problem is related to picking > up copies of our libraries from outside the build tree. Do you have > any copies of libpgport.a/.so or libpgcommon.a/.so in > /usr/local/lib or /usr/lib or /lib ? Ah, no, scratch that, I see the problem. In v10, p

Re: peripatus build failures....

2018-07-07 Thread Larry Rosenman
On Sat, Jul 07, 2018 at 01:33:26PM -0500, Larry Rosenman wrote: > On Sat, Jul 07, 2018 at 02:28:17PM -0400, Tom Lane wrote: > > Larry Rosenman writes: > > > And the winner is: > > > > > dddfc4cb2edcfa5497f5d50190a7fb046c51da16 is the first bad commit > > > commit dddfc4cb2edcfa5497f5d50190a7fb046

Re: peripatus build failures....

2018-07-07 Thread Larry Rosenman
On Sat, Jul 07, 2018 at 02:28:17PM -0400, Tom Lane wrote: > Larry Rosenman writes: > > And the winner is: > > > dddfc4cb2edcfa5497f5d50190a7fb046c51da16 is the first bad commit > > commit dddfc4cb2edcfa5497f5d50190a7fb046c51da16 > > Author: Tom Lane > > Date: Tue Apr 3 16:26:05 2018 -0400 > >

Re: peripatus build failures....

2018-07-07 Thread Tom Lane
Larry Rosenman writes: > And the winner is: > dddfc4cb2edcfa5497f5d50190a7fb046c51da16 is the first bad commit > commit dddfc4cb2edcfa5497f5d50190a7fb046c51da16 > Author: Tom Lane > Date: Tue Apr 3 16:26:05 2018 -0400 > > Prevent accidental linking of system-supplied copies of libpq.so etc

Re: peripatus build failures....

2018-07-07 Thread Larry Rosenman
On Sat, Jul 07, 2018 at 11:24:48AM -0400, Tom Lane wrote: > Larry Rosenman writes: > > On Sat, Jul 07, 2018 at 11:11:24AM -0400, Tom Lane wrote: > >> Larry Rosenman writes: > >>> f044d71e331d77a0039cec0a11859b5a3c72bc95 fixed it. > > >> Don't think I believe that conclusion; that patch shouldn't

Re: peripatus build failures....

2018-07-07 Thread Tom Lane
Larry Rosenman writes: > On Sat, Jul 07, 2018 at 11:11:24AM -0400, Tom Lane wrote: >> Larry Rosenman writes: >>> f044d71e331d77a0039cec0a11859b5a3c72bc95 fixed it. >> Don't think I believe that conclusion; that patch shouldn't >> have affected anything at all for non-ARM architectures. > Those

Re: peripatus build failures....

2018-07-07 Thread Larry Rosenman
On Sat, Jul 07, 2018 at 11:11:24AM -0400, Tom Lane wrote: > Larry Rosenman writes: > > f044d71e331d77a0039cec0a11859b5a3c72bc95 fixed it. > > Don't think I believe that conclusion; that patch shouldn't > have affected anything at all for non-ARM architectures. > > regards,

Re: peripatus build failures....

2018-07-07 Thread Tom Lane
Larry Rosenman writes: > f044d71e331d77a0039cec0a11859b5a3c72bc95 fixed it. Don't think I believe that conclusion; that patch shouldn't have affected anything at all for non-ARM architectures. regards, tom lane

Re: peripatus build failures....

2018-07-06 Thread Larry Rosenman
On Fri, Jul 06, 2018 at 07:18:46PM -0400, Tom Lane wrote: > Larry Rosenman writes: > > On Fri, Jul 06, 2018 at 06:40:49PM -0400, Tom Lane wrote: > >> I do not like the "-Wl,-z,notext" thing at all. It fails to explain > >> why things are working OK in v11/HEAD, which makes me think that it's > >>

Re: peripatus build failures....

2018-07-06 Thread Tom Lane
Larry Rosenman writes: > On Fri, Jul 06, 2018 at 06:40:49PM -0400, Tom Lane wrote: >> I do not like the "-Wl,-z,notext" thing at all. It fails to explain >> why things are working OK in v11/HEAD, which makes me think that it's >> band-aiding something rather than really fixing it. > Following th

Re: peripatus build failures....

2018-07-06 Thread Larry Rosenman
On Fri, Jul 06, 2018 at 06:05:36PM -0500, Larry Rosenman wrote: > On Fri, Jul 06, 2018 at 06:40:49PM -0400, Tom Lane wrote: > > Larry Rosenman writes: > > > anyone want to look at this, or at least give me a clue on how to add > > > this to 10 & below? > > > > I do not like the "-Wl,-z,notext" th

Re: peripatus build failures....

2018-07-06 Thread Larry Rosenman
On Fri, Jul 06, 2018 at 06:40:49PM -0400, Tom Lane wrote: > Larry Rosenman writes: > > anyone want to look at this, or at least give me a clue on how to add > > this to 10 & below? > > I do not like the "-Wl,-z,notext" thing at all. It fails to explain > why things are working OK in v11/HEAD, wh

Re: peripatus build failures....

2018-07-06 Thread Tom Lane
Larry Rosenman writes: > anyone want to look at this, or at least give me a clue on how to add > this to 10 & below? I do not like the "-Wl,-z,notext" thing at all. It fails to explain why things are working OK in v11/HEAD, which makes me think that it's band-aiding something rather than really

Re: peripatus build failures....

2018-07-06 Thread Larry Rosenman
On Thu, Jul 05, 2018 at 07:47:39AM -0500, Larry Rosenman wrote: > On Wed, Jul 04, 2018 at 08:37:40PM -0500, Larry Rosenman wrote: > > On Wed, Jul 04, 2018 at 08:19:48PM -0500, Larry Rosenman wrote: > > > On Thu, Jul 05, 2018 at 12:56:49PM +1200, Thomas Munro wrote: > > > > On Thu, Jul 5, 2018 at 12

Re: peripatus build failures....

2018-07-05 Thread Larry Rosenman
On Wed, Jul 04, 2018 at 08:37:40PM -0500, Larry Rosenman wrote: > On Wed, Jul 04, 2018 at 08:19:48PM -0500, Larry Rosenman wrote: > > On Thu, Jul 05, 2018 at 12:56:49PM +1200, Thomas Munro wrote: > > > On Thu, Jul 5, 2018 at 12:35 PM, Larry Rosenman wrote: > > > > I agree. Is there an easy way I

Re: peripatus build failures....

2018-07-04 Thread Larry Rosenman
On Wed, Jul 04, 2018 at 08:19:48PM -0500, Larry Rosenman wrote: > On Thu, Jul 05, 2018 at 12:56:49PM +1200, Thomas Munro wrote: > > On Thu, Jul 5, 2018 at 12:35 PM, Larry Rosenman wrote: > > > I agree. Is there an easy way I can add this work around to peripatus' > > > source tree: > > > > > > It

Re: peripatus build failures....

2018-07-04 Thread Larry Rosenman
On Thu, Jul 05, 2018 at 12:56:49PM +1200, Thomas Munro wrote: > On Thu, Jul 5, 2018 at 12:35 PM, Larry Rosenman wrote: > > I agree. Is there an easy way I can add this work around to peripatus' > > source tree: > > > > It may be that adding "LDFLAGS+= -Wl,-z,notext" (and removing LLD_UNSAFE) > >

Re: peripatus build failures....

2018-07-04 Thread Thomas Munro
On Thu, Jul 5, 2018 at 12:35 PM, Larry Rosenman wrote: > I agree. Is there an easy way I can add this work around to peripatus' > source tree: > > It may be that adding "LDFLAGS+= -Wl,-z,notext" (and removing LLD_UNSAFE) > will let the port build with lld. Maybe something like this at the end o

Re: peripatus build failures....

2018-07-04 Thread Larry Rosenman
On Wed, Jul 04, 2018 at 07:35:28PM -0500, Larry Rosenman wrote: > On Thu, Jul 05, 2018 at 12:30:37PM +1200, Thomas Munro wrote: > > On Thu, Jul 5, 2018 at 11:43 AM, Larry Rosenman wrote: > > > I noticed my buildfarm member peripatus hadn't been building due to me > > > missing a perl library. Aft

Re: peripatus build failures....

2018-07-04 Thread Larry Rosenman
On Thu, Jul 05, 2018 at 12:30:37PM +1200, Thomas Munro wrote: > On Thu, Jul 5, 2018 at 11:43 AM, Larry Rosenman wrote: > > I noticed my buildfarm member peripatus hadn't been building due to me > > missing a perl library. After I fixed that I get failures on: > > > > Buildfarm member peripatus fa

Re: peripatus build failures....

2018-07-04 Thread Thomas Munro
On Thu, Jul 5, 2018 at 11:43 AM, Larry Rosenman wrote: > I noticed my buildfarm member peripatus hadn't been building due to me > missing a perl library. After I fixed that I get failures on: > > Buildfarm member peripatus failed on REL9_3_STABLE stage Make > Buildfarm member peripatus failed on

peripatus build failures....

2018-07-04 Thread Larry Rosenman
I noticed my buildfarm member peripatus hadn't been building due to me missing a perl library. After I fixed that I get failures on: Buildfarm member peripatus failed on REL9_3_STABLE stage Make Buildfarm member peripatus failed on REL9_4_STABLE stage Make Buildfarm member peripatus failed on REL