Re: perltidy version

2018-04-25 Thread Tom Lane
"Tels" writes: > On Wed, April 25, 2018 12:35 pm, Tom Lane wrote: >> Agreed on pointing to cpan, but that page is pretty confusing if you're >> looking for a non-bleeding-edge version. I suggest linking to >> https://cpan.metacpan.org/authors/id/S/SH/SHANCOCK/ >> which presents a handy directory

Re: perltidy version

2018-04-25 Thread Tels
Moin, On Wed, April 25, 2018 12:35 pm, Tom Lane wrote: > Michael Paquier writes: >> On Mon, Apr 23, 2018 at 12:40:00PM -0400, Tom Lane wrote: >>> Alvaro Herrera writes: I still vote we use 20170521 which is recent enough that we won't have to change it in a few years. > >> That's the v

Re: perltidy version

2018-04-25 Thread Alvaro Herrera
Tom Lane wrote: > Alvaro Herrera writes: > > Tom Lane wrote: > >> Agreed on pointing to cpan, but that page is pretty confusing if you're > >> looking for a non-bleeding-edge version. I suggest linking to > >> https://cpan.metacpan.org/authors/id/S/SH/SHANCOCK/ > >> which presents a handy directo

Re: perltidy version

2018-04-25 Thread Tom Lane
Alvaro Herrera writes: > Tom Lane wrote: >> Agreed on pointing to cpan, but that page is pretty confusing if you're >> looking for a non-bleeding-edge version. I suggest linking to >> https://cpan.metacpan.org/authors/id/S/SH/SHANCOCK/ >> which presents a handy directory listing. > Works for me.

Re: perltidy version

2018-04-25 Thread Alvaro Herrera
Tom Lane wrote: > Michael Paquier writes: > > On Mon, Apr 23, 2018 at 12:40:00PM -0400, Tom Lane wrote: > >> Alvaro Herrera writes: > >>> I further vote that we change the URL in pgindent/README from > >>> sourceforge to metacpan.org, > >>> https://metacpan.org/pod/distribution/Perl-Tidy/lib/Per

Re: perltidy version

2018-04-25 Thread Tom Lane
Michael Paquier writes: > On Mon, Apr 23, 2018 at 12:40:00PM -0400, Tom Lane wrote: >> Alvaro Herrera writes: >>> I still vote we use 20170521 which is recent enough that we won't have >>> to change it in a few years. > That's the version available on Debian sid, so from the prospective of > any

Re: perltidy version

2018-04-23 Thread Michael Paquier
On Mon, Apr 23, 2018 at 12:40:00PM -0400, Tom Lane wrote: > Alvaro Herrera writes: >> I still vote we use 20170521 which is recent enough that we won't have >> to change it in a few years. That's the version available on Debian sid, so from the prospective of any Debian user this is a handy versi

Re: perltidy version

2018-04-23 Thread Tom Lane
Alvaro Herrera writes: > Peter Eisentraut wrote: >> Did we decide on this? > No agreement yet apparently :-) > I still vote we use 20170521 which is recent enough that we won't have > to change it in a few years. > I further vote that we change the URL in pgindent/README from > sourceforge to m

Re: perltidy version

2018-04-23 Thread Alvaro Herrera
Peter Eisentraut wrote: > On 3/5/18 09:02, Magnus Hagander wrote: > > I think we should just pick some recent one and use it for X years; use > > that one for all backbranches.  I propose X=3.  I propose 20170521 > > (newer ones seem to cater for stuff that I think we mostly don't use).

Re: perltidy version

2018-04-23 Thread Peter Eisentraut
On 3/5/18 09:02, Magnus Hagander wrote: > I think we should just pick some recent one and use it for X years; use > that one for all backbranches.  I propose X=3.  I propose 20170521 > (newer ones seem to cater for stuff that I think we mostly don't use). > > > 20140328 seems to cover

Re: perltidy version

2018-03-05 Thread Magnus Hagander
On Mon, Mar 5, 2018 at 2:53 PM, Alvaro Herrera wrote: > Magnus Hagander wrote: > > > For example, Debian ships with 20140328, which produces the attached > diff. > > I'm not sure if we want to go to whatever is a "common version on most > > platforms" today, or just "whatever is latest" if we do

Re: perltidy version

2018-03-05 Thread Alvaro Herrera
Magnus Hagander wrote: > For example, Debian ships with 20140328, which produces the attached diff. > I'm not sure if we want to go to whatever is a "common version on most > platforms" today, or just "whatever is latest" if we do upgrade. AFAICT > RHEL 7 seems to be on 20121207, RHEL 6 on 2009061

Re: perltidy version

2018-03-04 Thread Daniel Gustafsson
> On 04 Mar 2018, at 00:03, Tom Lane wrote: > > Magnus Hagander writes: >> Ah yeah, if I apply that one first, the diff from using 20140328 is much >> smaller. Attached is that one, which means the difference between the two >> perltidy versions. > > I'm hardly a Perl guru, so I'm not going to

Re: perltidy version

2018-03-04 Thread Andrew Dunstan
On Sun, Mar 4, 2018 at 9:33 AM, Tom Lane wrote: > Magnus Hagander writes: >> Ah yeah, if I apply that one first, the diff from using 20140328 is much >> smaller. Attached is that one, which means the difference between the two >> perltidy versions. > > I'm hardly a Perl guru, so I'm not going to

Re: perltidy version

2018-03-03 Thread Tom Lane
Magnus Hagander writes: > Ah yeah, if I apply that one first, the diff from using 20140328 is much > smaller. Attached is that one, which means the difference between the two > perltidy versions. I'm hardly a Perl guru, so I'm not going to opine on whether these changes are for the better or wors

Re: perltidy version

2018-03-03 Thread Magnus Hagander
On Fri, Mar 2, 2018 at 4:49 PM, Tom Lane wrote: > Magnus Hagander writes: > > On Fri, Mar 2, 2018 at 3:53 PM, Tom Lane wrote: > >> +1. We're not that far away from it being time to run > pgindent/perltidy, > >> so now would be a good time to consider whether we like a newer > version's > >> re

Re: perltidy version

2018-03-02 Thread Tom Lane
Magnus Hagander writes: > On Fri, Mar 2, 2018 at 3:53 PM, Tom Lane wrote: >> +1. We're not that far away from it being time to run pgindent/perltidy, >> so now would be a good time to consider whether we like a newer version's >> result better. > For example, Debian ships with 20140328, which p

Re: perltidy version

2018-03-02 Thread Tom Lane
Alvaro Herrera writes: > Magnus Hagander wrote: >> In that case, we should at least update our instructions for how to install >> it. But that's definitely a better option than hosting our own copy. > But surely the idea of updating the version to use should be considered > further? Maybe they h

Re: perltidy version

2018-03-02 Thread Alvaro Herrera
Magnus Hagander wrote: > In that case, we should at least update our instructions for how to install > it. But that's definitely a better option than hosting our own copy. But surely the idea of updating the version to use should be considered further? Maybe they have even improved the output ;-

Re: perltidy version

2018-03-02 Thread Magnus Hagander
On Fri, Mar 2, 2018 at 1:30 PM, Dagfinn Ilmari Mannsåker wrote: > Magnus Hagander writes: > > > Our instructions in src/tools/pgindent/README says to make sure we use > > perltidy version v20090616. However, this version no longer appears to be > > available for downloa

Re: perltidy version

2018-03-02 Thread Dagfinn Ilmari Mannsåker
Magnus Hagander writes: > Our instructions in src/tools/pgindent/README says to make sure we use > perltidy version v20090616. However, this version no longer appears to be > available for download on the link we provide -- the oldest one available > is 20140328. It's avail

perltidy version

2018-03-02 Thread Magnus Hagander
Our instructions in src/tools/pgindent/README says to make sure we use perltidy version v20090616. However, this version no longer appears to be available for download on the link we provide -- the oldest one available is 20140328. Is it perhaps time to move up to a newer version? Or failing that