Re: pg12 release notes

2019-05-13 Thread Bruce Momjian
On Mon, May 13, 2019 at 12:48:00PM -0500, Justin Pryzby wrote: > On Fri, May 10, 2019 at 05:10:06PM +1200, David Rowley wrote: > > On Fri, 10 May 2019 at 16:52, Justin Pryzby wrote: > > > I'm rechecking my list from last month. What about these ? > > > > > > > c076f3d Remove

Re: pg12 release notes

2019-05-13 Thread Michael Paquier
On Mon, May 13, 2019 at 12:48:00PM -0500, Justin Pryzby wrote: > I suspect c076f3d should be included, though. bd47c4a9 has removed pg_constraint.conincluding from REL_11_STABLE as well. -- Michael signature.asc Description: PGP signature

Re: pg12 release notes

2019-05-13 Thread Justin Pryzby
On Fri, May 10, 2019 at 05:10:06PM +1200, David Rowley wrote: > On Fri, 10 May 2019 at 16:52, Justin Pryzby wrote: > > I'm rechecking my list from last month. What about these ? > > > > > c076f3d Remove pg_constraint.conincluding > > > bd09503 Increase the default vacuum_cost_limit from 200 to

Re: pg12 release notes

2019-05-11 Thread Bruce Momjian
On Sat, May 11, 2019 at 11:47:42AM -0700, Peter Geoghegan wrote: > On Sat, May 11, 2019 at 11:02 AM Bruce Momjian wrote: > > OK, commit removed. > > You're mistaken -- nothing has been pushed to master in the last 3 hours. I am not mistaken. I have removed it from my local copy, but have not

Re: pg12 release notes

2019-05-11 Thread Peter Geoghegan
On Sat, May 11, 2019 at 11:02 AM Bruce Momjian wrote: > OK, commit removed. You're mistaken -- nothing has been pushed to master in the last 3 hours. -- Peter Geoghegan

Re: pg12 release notes

2019-05-11 Thread Bruce Momjian
On Sat, May 11, 2019 at 10:28:08AM -0700, Peter Geoghegan wrote: > On Sat, May 11, 2019 at 7:40 AM Bruce Momjian wrote: > > > > > I think I have understood the nuances, as listed above --- I just > > > > > don't > > > > > agree with the solution. > > > > > > > > To be clear, I don't expect you

Re: pg12 release notes

2019-05-11 Thread Peter Geoghegan
On Sat, May 11, 2019 at 7:40 AM Bruce Momjian wrote: > > > > I think I have understood the nuances, as listed above --- I just don't > > > > agree with the solution. > > > > > > To be clear, I don't expect you to agree with the solution. > > > > > > Another thing that you missed from my patch is

Re: pg12 release notes

2019-05-11 Thread Bruce Momjian
On Sat, May 11, 2019 at 10:36:13AM -0400, Bruce Momjian wrote: > On Fri, May 10, 2019 at 07:31:21PM -0700, Peter Geoghegan wrote: > > > I think I have understood the nuances, as listed above --- I just don't > > > agree with the solution. > > > > To be clear, I don't expect you to agree with the

Re: pg12 release notes

2019-05-11 Thread Bruce Momjian
On Fri, May 10, 2019 at 07:31:21PM -0700, Peter Geoghegan wrote: > On Fri, May 10, 2019 at 7:11 PM Bruce Momjian wrote: > > > Whether or not you include more details is not what I care about here > > > -- I *agree* that this is insignificant. > > > Well, we can move the entire item up to the

Re: pg12 release notes

2019-05-11 Thread Bruce Momjian
On Sat, May 11, 2019 at 03:06:40AM +0100, Andrew Gierth wrote: > > "Bruce" == Bruce Momjian writes: > Bruce> Do I need more? > > That isn't quite how I'd have worded it, but I'm not sure what the best > wording is. Something like: > > * Output REAL and DOUBLE PRECISION values in

Re: pg12 release notes

2019-05-10 Thread Peter Geoghegan
On Fri, May 10, 2019 at 7:11 PM Bruce Momjian wrote: > > Whether or not you include more details is not what I care about here > > -- I *agree* that this is insignificant. > Well, we can move the entire item up to the incompatibility section, but > that seems unbalanced since the

Re: pg12 release notes

2019-05-10 Thread Bruce Momjian
On Fri, May 10, 2019 at 06:53:55PM -0700, Peter Geoghegan wrote: > On Fri, May 10, 2019 at 6:02 PM Bruce Momjian wrote: > > Have new btree indexes sort duplicate index entries in heap-storage > > order (Peter Geoghegan) > > > > This slightly reduces the maximum-allowed

Re: pg12 release notes

2019-05-10 Thread Andrew Gierth
> "Bruce" == Bruce Momjian writes: >> I noticed that the compatibility note for Andrew Gierth's RYU >> floating point patch seems to simply say why the feature is useful. >> Shouldn't it be listed separately, and its impact on users upgrading >> be listed here instead? Bruce> The text

Re: pg12 release notes

2019-05-10 Thread Peter Geoghegan
On Fri, May 10, 2019 at 6:02 PM Bruce Momjian wrote: > Have new btree indexes sort duplicate index entries in heap-storage > order (Peter Geoghegan) > > This slightly reduces the maximum-allowed length of indexed values. >

Re: pg12 release notes

2019-05-10 Thread Bruce Momjian
On Fri, May 10, 2019 at 03:34:15PM +1200, David Rowley wrote: > On Fri, 10 May 2019 at 13:03, Bruce Momjian wrote: > > > > On Thu, May 9, 2019 at 07:13:35PM -0500, Justin Pryzby wrote: > > > On Thu, May 09, 2019 at 07:35:18PM -0400, Bruce Momjian wrote: > > > > I have made your other changes,

Re: pg12 release notes

2019-05-10 Thread Bruce Momjian
On Thu, May 9, 2019 at 07:10:43PM -0700, Peter Geoghegan wrote: > On Thu, May 9, 2019 at 6:03 PM Bruce Momjian wrote: > > These were all very helpful. I adjusted your changes to create the > > attached applied patch. URL updated: > > I noticed that the compatibility note for Andrew Gierth's

Re: pg12 release notes

2019-05-10 Thread Bruce Momjian
On Thu, May 9, 2019 at 08:34:49PM -0500, Justin Pryzby wrote: > On Thu, May 09, 2019 at 09:02:51PM -0400, Bruce Momjian wrote: > > These were all very helpful. I adjusted your changes to create the > > attached applied patch. URL updated: > > Thanks. > > > -Allow more comparisons with

Re: pg12 release notes

2019-05-10 Thread Tom Lane
Alvaro Herrera writes: > Still, it's an inconsistency in pg11. I vote -0 to getting it > backpatched, mostly because it seems like more work than is warranted. > (I think the work consists not only of testing that the backpatched > commit works correctly, but also documenting for 11.4 release

Re: pg12 release notes

2019-05-10 Thread Alvaro Herrera
On 2019-May-10, Amit Langote wrote: > On 2019/05/10 12:18, David Rowley wrote: > > On Fri, 10 May 2019 at 12:08, Bruce Momjian wrote: > >>> 17f206f Set pg_class.relhassubclass for partitioned indexes > >> > >> I need help with this one. I know the system column existed in previous > >>

Re: pg12 release notes

2019-05-09 Thread Amit Langote
Hi David, On 2019/05/10 14:51, David Rowley wrote: > On Fri, 10 May 2019 at 16:57, Justin Pryzby wrote: >>> 959d00e Use Append rather than MergeAppend for scanning ordered partitions. > > I also think this is worth a mention. The speedup can be quite large > when the query involves a LIMIT

Re: pg12 release notes

2019-05-09 Thread David Rowley
On Fri, 10 May 2019 at 16:57, Justin Pryzby wrote: > > 8edd0e7 Suppress Append and MergeAppend plan nodes that have a single child. You could say that I'm biased, but I think this should get a mention. It's not just a matter of tidying up the plan by getting rid of nodes that are not requires,

Re: pg12 release notes

2019-05-09 Thread David Rowley
On Fri, 10 May 2019 at 16:52, Justin Pryzby wrote: > I'm rechecking my list from last month. What about these ? > > > c076f3d Remove pg_constraint.conincluding > > bd09503 Increase the default vacuum_cost_limit from 200 to 2000 bd09503 was reverted in 52985e4fea7 and replaced by cbccac371,

Re: pg12 release notes

2019-05-09 Thread Justin Pryzby
On Fri, May 10, 2019 at 12:45:54PM +0900, Amit Langote wrote: > On 2019/05/10 12:18, David Rowley wrote: > > On Fri, 10 May 2019 at 12:08, Bruce Momjian wrote: > >>> 17f206f Set pg_class.relhassubclass for partitioned indexes > >> > >> I need help with this one. I know the system column existed

Re: pg12 release notes

2019-05-09 Thread Justin Pryzby
On Thu, May 09, 2019 at 08:08:53PM -0400, Bruce Momjian wrote: > On Wed, May 8, 2019 at 03:32:04PM -0500, Justin Pryzby wrote: > > I noticed you added release notes at > > bdf595adbca195fa54a909c74a5233ebc30641a1, > > thanks for writing them. > > > > I reviewed notes; find proposed changes

Re: pg12 release notes

2019-05-09 Thread Tom Lane
David Rowley writes: > I think you might be mixing up two items. I'm talking about: > > Allow IN comparisons with arrays to use IS NOT NULL > partial indexes more frequently (Tom Lane) > > to which the sgml references 65ce07e02. Wups, sorry, I was talking about 65ce07e02 also, but I managed

Re: pg12 release notes

2019-05-09 Thread David Rowley
On Fri, 10 May 2019 at 15:45, Tom Lane wrote: > > > > Allow IS NOT NULL with mis-matching types to use partial indexes more > frequently (Tom Lane) > > > > If so, I think James Coleman should be the author. > > ... and yeah, James should get the credit. But there's more wrong with > the

Re: pg12 release notes

2019-05-09 Thread Amit Langote
On 2019/05/10 12:18, David Rowley wrote: > On Fri, 10 May 2019 at 12:08, Bruce Momjian wrote: >>> 17f206f Set pg_class.relhassubclass for partitioned indexes >> >> I need help with this one. I know the system column existed in previous >> releases, so how is it different now? Do we document

Re: pg12 release notes

2019-05-09 Thread Tom Lane
David Rowley writes: > Just a question about the item: "Allow IN comparisons with arrays to > use IS NOT NULL partial indexes more frequently (Tom Lane)" > From what I can tell this must refer to 65ce07e0202f. You can tell for sure by looking into the SGML comments in release-12.sgml: Allow

Re: pg12 release notes

2019-05-09 Thread David Rowley
On Fri, 10 May 2019 at 13:03, Bruce Momjian wrote: > > On Thu, May 9, 2019 at 07:13:35PM -0500, Justin Pryzby wrote: > > On Thu, May 09, 2019 at 07:35:18PM -0400, Bruce Momjian wrote: > > > I have made your other changes, with adjustment, patch attached. > > > > > > The results are here: > > > >

Re: pg12 release notes

2019-05-09 Thread David Rowley
On Fri, 10 May 2019 at 12:08, Bruce Momjian wrote: > > 17f206f Set pg_class.relhassubclass for partitioned indexes > > I need help with this one. I know the system column existed in previous > releases, so how is it different now? Do we document system table > changes that are

Re: pg12 release notes

2019-05-09 Thread Peter Geoghegan
On Thu, May 9, 2019 at 6:03 PM Bruce Momjian wrote: > These were all very helpful. I adjusted your changes to create the > attached applied patch. URL updated: I noticed that the compatibility note for Andrew Gierth's RYU floating point patch seems to simply say why the feature is useful.

Re: pg12 release notes

2019-05-09 Thread Justin Pryzby
On Thu, May 09, 2019 at 09:02:51PM -0400, Bruce Momjian wrote: > These were all very helpful. I adjusted your changes to create the > attached applied patch. URL updated: Thanks. > -Allow more comparisons with information_schema text columns to use indexes > (Tom Lane) > +Allow more use of

Re: pg12 release notes

2019-05-09 Thread Bruce Momjian
On Thu, May 9, 2019 at 07:13:35PM -0500, Justin Pryzby wrote: > On Thu, May 09, 2019 at 07:35:18PM -0400, Bruce Momjian wrote: > > I have made your other changes, with adjustment, patch attached. > > > > The results are here: > > > > http://momjian.us/pgsql_docs/release-12.html > > Thanks

Re: pg12 release notes

2019-05-09 Thread Bruce Momjian
On Thu, May 9, 2019 at 07:19:59PM -0500, Justin Pryzby wrote: > > +Author: Thomas Munro > > +2018-07-13 [387a5cfb9] Add pg_dump - -on-conflict-do-nothing option. > > +--> > > + > > + > > +Allow restore of INSERT statements to skip rows which would cause > > conflicts (Surafel Temesgen) > > + >

Re: pg12 release notes

2019-05-09 Thread Justin Pryzby
On Thu, May 09, 2019 at 07:35:18PM -0400, Bruce Momjian wrote: > I have made your other changes, with adjustment, patch attached. > > The results are here: > > http://momjian.us/pgsql_docs/release-12.html Thanks > -Many system tables now have an 'oid' column that will be expanded with >

Re: pg12 release notes

2019-05-09 Thread Justin Pryzby
On Thu, May 09, 2019 at 08:08:53PM -0400, Bruce Momjian wrote: > On Wed, May 8, 2019 at 03:32:04PM -0500, Justin Pryzby wrote: > > I think these should also be mentioned? > > > > f7cb284 Add plan_cache_mode setting > > 387a5cf Add pg_dump --on-conflict-do-nothing option. > > Applied patch

Re: pg12 release notes

2019-05-09 Thread Bruce Momjian
On Wed, May 8, 2019 at 03:32:04PM -0500, Justin Pryzby wrote: > I noticed you added release notes at bdf595adbca195fa54a909c74a5233ebc30641a1, > thanks for writing them. > > I reviewed notes; find proposed changes attached+included. > > I think these should also be mentioned? > > f7cb284 Add

Re: pg12 release notes

2019-05-09 Thread Bruce Momjian
On Wed, May 8, 2019 at 03:32:04PM -0500, Justin Pryzby wrote: > I noticed you added release notes at bdf595adbca195fa54a909c74a5233ebc30641a1, > thanks for writing them. > -This improve optimization for columns with non-uniform distributions that > often appear in WHERE clauses. > +This

Re: pg12 release notes

2019-05-09 Thread Thomas Munro
On Thu, May 9, 2019 at 8:32 AM Justin Pryzby wrote: > I noticed you added release notes at bdf595adbca195fa54a909c74a5233ebc30641a1, > thanks for writing them. +1 > I reviewed notes; find proposed changes attached+included. +1 to all the corrections shown. One more: "Allow parallel query

Re: pg12 release notes

2019-05-08 Thread Alvaro Herrera
On 2019-May-08, Justin Pryzby wrote: > I noticed you added release notes at bdf595adbca195fa54a909c74a5233ebc30641a1, > thanks for writing them. > > I reviewed notes; find proposed changes attached+included. > > I think these should also be mentioned? > > a6da004 Add index_get_partition

pg12 release notes

2019-05-08 Thread Justin Pryzby
ection of System V shared memory, if desired. >From a2d7fccc8cd8035898a4459e4b7176ef1168f713 Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Wed, 8 May 2019 15:22:36 -0500 Subject: [PATCH v1] review pg12 release notes --- doc/src/sgml/release-12.sgml | 37 +++