Re: pg13 PGDLLIMPORT list

2020-01-20 Thread Craig Ringer
On Tue, 21 Jan 2020 at 12:49, Michael Paquier wrote: > > On Tue, Jan 21, 2020 at 08:34:05AM +0530, Amit Kapila wrote: > > As such no objection, but I am not sure if the other person need it on > > back branches as well. Are you planning to commit this, or if you > > want I can take care of it? >

Re: pg13 PGDLLIMPORT list

2020-01-20 Thread Michael Paquier
On Tue, Jan 21, 2020 at 08:34:05AM +0530, Amit Kapila wrote: > As such no objection, but I am not sure if the other person need it on > back branches as well. Are you planning to commit this, or if you > want I can take care of it? Thanks for the reminder. Done now. I have also switched the

Re: pg13 PGDLLIMPORT list

2020-01-20 Thread Amit Kapila
On Sat, Jan 18, 2020 at 3:19 PM Michael Paquier wrote: > > On Sat, Jan 18, 2020 at 09:19:19AM +0200, Julien Rouhaud wrote: > > On Sat, 18 Jan 2020, 09:04 Amit Kapila >> +1 for adding PGDLLIMPORT to these variables. In the past, we have > >> added it on the request of some extension authors, so

Re: pg13 PGDLLIMPORT list

2020-01-18 Thread Michael Paquier
On Sat, Jan 18, 2020 at 09:19:19AM +0200, Julien Rouhaud wrote: > On Sat, 18 Jan 2020, 09:04 Amit Kapila > +1 for adding PGDLLIMPORT to these variables. In the past, we have >> added it on the request of some extension authors, so I don't see any >> problem doing this time as well. >> > > +1 too

Re: pg13 PGDLLIMPORT list

2020-01-18 Thread Michael Paquier
On Sat, Jan 18, 2020 at 02:32:49AM -0700, legrand legrand wrote: > No specific use-case, just the need to test features (IVM, push agg to base > relations and joins, ...) > on a professional laptop in windows 10 for a nomad app that collects > performance metrics on Oracle > databases. That

Re: pg13 PGDLLIMPORT list

2020-01-18 Thread legrand legrand
Michael Paquier-2 wrote > On Fri, Jan 17, 2020 at 03:07:48PM -0700, legrand legrand wrote: > [...] > > No objections from me to add both to what's imported. Do you have a > specific use-case in mind for an extension on Windows? Just > wondering.. > -- > Michael > > signature.asc (849 bytes) >

Re: pg13 PGDLLIMPORT list

2020-01-17 Thread Julien Rouhaud
On Sat, 18 Jan 2020, 09:04 Amit Kapila On Sat, Jan 18, 2020 at 7:56 AM Michael Paquier > wrote: > > > > On Fri, Jan 17, 2020 at 03:07:48PM -0700, legrand legrand wrote: > > > Would it be possible to add PGDLLIMPORT to permit to build following > > > extensions on windows > > > > > >

Re: pg13 PGDLLIMPORT list

2020-01-17 Thread Amit Kapila
On Sat, Jan 18, 2020 at 7:56 AM Michael Paquier wrote: > > On Fri, Jan 17, 2020 at 03:07:48PM -0700, legrand legrand wrote: > > Would it be possible to add PGDLLIMPORT to permit to build following > > extensions on windows > > > > pg_stat_sql_plans: > > src/include/pgstat.h > > extern PGDLLIMPORT

Re: pg13 PGDLLIMPORT list

2020-01-17 Thread Michael Paquier
On Fri, Jan 17, 2020 at 03:07:48PM -0700, legrand legrand wrote: > Would it be possible to add PGDLLIMPORT to permit to build following > extensions on windows > > pg_stat_sql_plans: > src/include/pgstat.h > extern PGDLLIMPORT bool pgstat_track_activities; > > pg_background: >

pg13 PGDLLIMPORT list

2020-01-17 Thread legrand legrand
Hello, would it be possible to add PGDLLIMPORT to permit to build following extensions on windows pg_stat_sql_plans: src/include/pgstat.h extern PGDLLIMPORT bool pgstat_track_activities; pg_background: src/include/storage/proc.h extern PGDLLIMPORT int StatementTimeout; Thanks in advance