Re: pg_basebackup misses to report checksum error

2020-05-07 Thread Ashwin Agrawal
On Thu, May 7, 2020 at 10:25 AM Stephen Frost wrote: > Greetings, > > * Ashwin Agrawal (aagra...@pivotal.io) wrote: > > On Wed, May 6, 2020 at 3:02 PM Robert Haas > wrote: > > > On Wed, May 6, 2020 at 5:48 PM Ashwin Agrawal > wrote: > > > > If pg_basebackup is not able to read BLCKSZ content

Re: pg_basebackup misses to report checksum error

2020-05-07 Thread Stephen Frost
Greetings, * Ashwin Agrawal (aagra...@pivotal.io) wrote: > On Wed, May 6, 2020 at 3:02 PM Robert Haas wrote: > > On Wed, May 6, 2020 at 5:48 PM Ashwin Agrawal wrote: > > > If pg_basebackup is not able to read BLCKSZ content from file, then it > > > just emits a warning "could not verify

Re: pg_basebackup misses to report checksum error

2020-05-07 Thread Ashwin Agrawal
On Wed, May 6, 2020 at 3:02 PM Robert Haas wrote: > On Wed, May 6, 2020 at 5:48 PM Ashwin Agrawal wrote: > > If pg_basebackup is not able to read BLCKSZ content from file, then it > > just emits a warning "could not verify checksum in file "" block > > X: read buffer size X and page size

Re: pg_basebackup misses to report checksum error

2020-05-06 Thread Robert Haas
On Wed, May 6, 2020 at 5:48 PM Ashwin Agrawal wrote: > If pg_basebackup is not able to read BLCKSZ content from file, then it > just emits a warning "could not verify checksum in file "" block > X: read buffer size X and page size 8192 differ" currently but misses > to error with "checksum

pg_basebackup misses to report checksum error

2020-05-06 Thread Ashwin Agrawal
If pg_basebackup is not able to read BLCKSZ content from file, then it just emits a warning "could not verify checksum in file "" block X: read buffer size X and page size 8192 differ" currently but misses to error with "checksum error occurred". Only if it can read 8192 and checksum mismatch