pg_buffercache: add sql test

2022-06-06 Thread Dong Wook Lee
Hi, hackers I just wrote a test code for the `pg_buffercache` extension which doesn't not have test code. I wrote the sql query to ensure that the buffer cache results are the same when `make installcheck` is performed. --- regards Lee Dong Wook. 0001_add_test_pg_buffercache.patch Description: B

Re: pg_buffercache: add sql test

2022-07-30 Thread Tom Lane
Dong Wook Lee writes: > I just wrote a test code for the `pg_buffercache` extension which > doesn't not have test code. Pushed with minor adjustments. Some notes: * A .gitignore file is needed so that "git status" won't whine after running the test. This tends to be pretty much boilerplate; I

Re: pg_buffercache: add sql test

2022-07-31 Thread Julien Rouhaud
On Sun, Jul 31, 2022 at 3:39 AM Tom Lane wrote: > > * A .gitignore file is needed so that "git status" won't whine after > running the test. This tends to be pretty much boilerplate; I copied > it from another contrib directory. Is there any reason we don't add a .gitignore in the contrib/ direc

Re: pg_buffercache: add sql test

2022-08-01 Thread Dong Wook Lee
I've been missing what I have to add to the .gitignore file when I write the test. I will refer to it when I write the test code from now on. Thank you. 2022년 7월 31일 (일) 오전 4:39, Tom Lane 님이 작성: > > Dong Wook Lee writes: > > I just wrote a test code for the `pg_buffercache` extension which > > d

Re: pg_buffercache: add sql test

2022-06-06 Thread Daniel Gustafsson
> On 6 Jun 2022, at 15:30, Dong Wook Lee wrote: > I just wrote a test code for the `pg_buffercache` extension which > doesn't not have test code. Please add this patch to the next commitfest to make sure it's not lost before then. https://commitfest.postgresql.org/38/ -- Daniel Gustafs

Re: pg_buffercache: add sql test

2022-06-06 Thread Stephen Frost
Greetings, * Daniel Gustafsson (dan...@yesql.se) wrote: > > On 6 Jun 2022, at 15:30, Dong Wook Lee wrote: > > > I just wrote a test code for the `pg_buffercache` extension which > > doesn't not have test code. > > Please add this patch to the next commitfest to make sure it's not lost before >

Re: pg_buffercache: add sql test

2022-06-06 Thread Dong Wook Lee
I removed it on your advice. Thanks. 2022년 6월 7일 (화) 오전 2:04, Stephen Frost 님이 작성: > > Greetings, > > * Daniel Gustafsson (dan...@yesql.se) wrote: > > > On 6 Jun 2022, at 15:30, Dong Wook Lee wrote: > > > > > I just wrote a test code for the `pg_buffercache` extension which > > > doesn't not have