Re: pg_checksum: add test for coverage

2022-10-11 Thread Michael Paquier
On Mon, Aug 29, 2022 at 01:46:25PM +0200, Daniel Gustafsson wrote: > As written these tests aren't providing more coverage, they run more code but > they don't ensure that the produced output is correct. If you write these > tests with validation on the output they will be a lot more interesting.

Re: pg_checksum: add test for coverage

2022-08-29 Thread Daniel Gustafsson
> On 29 Aug 2022, at 13:26, Dong Wook Lee wrote: > I add a tiny test to pg_checksum for coverage. > I checked it improve test coverage 77.9% -> 87.7%. +# Checksums are verified if --progress arguments are specified +command_ok( + [ 'pg_checksums', '--progress', '-D', $pgdata ], + "ve

pg_checksum: add test for coverage

2022-08-29 Thread Dong Wook Lee
Hi, I add a tiny test to pg_checksum for coverage. I checked it improve test coverage 77.9% -> 87.7%. --- Regards, DongWook Lee. v1_add_test_to_pg_checksum.patch Description: Binary data