Re: pg_dumpall misses --no-toast-compression

2021-05-18 Thread Michael Paquier
On Tue, May 18, 2021 at 09:48:59AM +0900, Michael Paquier wrote: > Okay, thanks. I don't mind taking care of that on HEAD once beta1 is > shipped, then. Beta1 just got tagged, so this one has been applied as of 694da19. -- Michael signature.asc Description: PGP signature

Re: pg_dumpall misses --no-toast-compression

2021-05-17 Thread Michael Paquier
On Mon, May 17, 2021 at 10:38:15AM -0400, Tom Lane wrote: > Daniel Gustafsson writes: >> I think there is a reasonable case to be made for this fixing an oversight in >> bbe0a81db69bd10bd166907c3701492a29aca294 as opposed to adding a brand new >> feature. Save for --no-synchronized-snapshots all

Re: pg_dumpall misses --no-toast-compression

2021-05-17 Thread Tom Lane
Daniel Gustafsson writes: >> On 17 May 2021, at 03:12, Michael Paquier wrote: >> I have bumped into $subject while playing with this feature, and this >> can be really useful to be able to reset the compression method for >> all the tables at restore. The patch is simple but that's perhaps too >

Re: pg_dumpall misses --no-toast-compression

2021-05-17 Thread Daniel Gustafsson
> On 17 May 2021, at 03:12, Michael Paquier wrote: > I have bumped into $subject while playing with this feature, and this > can be really useful to be able to reset the compression method for > all the tables at restore. The patch is simple but that's perhaps too > late for 14, so I am adding i

Re: pg_dumpall misses --no-toast-compression

2021-05-16 Thread Dilip Kumar
On Mon, May 17, 2021 at 6:42 AM Michael Paquier wrote: > > Hi all, > > I have bumped into $subject while playing with this feature, and this > can be really useful to be able to reset the compression method for > all the tables at restore. This makes sense The patch is simple but that's perhap

pg_dumpall misses --no-toast-compression

2021-05-16 Thread Michael Paquier
Hi all, I have bumped into $subject while playing with this feature, and this can be really useful to be able to reset the compression method for all the tables at restore. The patch is simple but that's perhaps too late for 14, so I am adding it to the next CF. Thanks, -- Michael diff --git a/