Re: pg_locale compilation error with Visual Studio 2017

2018-05-12 Thread Tom Lane
Michael Paquier writes: > On Fri, May 11, 2018 at 10:39:07AM -0400, Tom Lane wrote: >> Another idea would be to replace the whole mess with a lookup table, >> although how to fill the table or maintain it in future would be >> problematic too. > Let's never do that.. Well,

Re: pg_locale compilation error with Visual Studio 2017

2018-05-12 Thread Michael Paquier
On Fri, May 11, 2018 at 10:39:07AM -0400, Tom Lane wrote: > In the other thread, Munro wondered if ResolveLocaleName() would do > the trick, but AFAICS nobody has tried it. Indeed. I am pretty sure that it would be worth looking into that. The VS docs shine by being obscure with this area, and

Re: pg_locale compilation error with Visual Studio 2017

2018-05-11 Thread Tom Lane
Sandeep Thakkar writes: > I found the same error was raised by someone in pgsql-general lists but > don't see the submitted patch was committed. Here is the discussion link >