Re: pg_restore -N loses extension comment

2024-05-07 Thread Tom Lane
I wrote: > I think this may be a bug in -l mode: ProcessArchiveRestoreOptions > saves the result of _tocEntryRequired in te->reqs, but PrintTOCSummary > doesn't, and that will bollix its subsequent _tocEntryRequired checks > for "dependent" TOC entries. Yeah ... the attached seems to fix it.

Re: pg_restore -N loses extension comment

2024-05-07 Thread Tom Lane
Justin Pryzby writes: > pg_dump -Fc |pg_restore -l -N schema: > | 2; 3079 18187 EXTENSION - pg_buffercache > Without -N schema also shows: > | 2562; 0 0 COMMENT - EXTENSION pg_buffercache Hmm, but what happens if you actually do the restore? I think this may be a bug in -l mode:

pg_restore -N loses extension comment

2024-05-07 Thread Justin Pryzby
pg_dump -Fc |pg_restore -l -N schema: | 2; 3079 18187 EXTENSION - pg_buffercache Without -N schema also shows: | 2562; 0 0 COMMENT - EXTENSION pg_buffercache I mean literal s-c-h-e-m-a, but I suppose anything else will work the same. BTW, I noticed that pg_restore -v shows that duplicate