Re: pg_verify_checksums vs windows

2018-08-31 Thread Amit Kapila
On Thu, Aug 30, 2018 at 5:04 PM Magnus Hagander wrote: > > On Thu, Aug 30, 2018 at 1:32 PM, Amit Kapila wrote: >> >> >> Okay. I will commit this in a day or so after once verifying it on >> PG11 as well. I think this needs to be backpatched, let me know if >> you think otherwise. >> > > Definit

Re: pg_verify_checksums vs windows

2018-08-30 Thread Magnus Hagander
On Thu, Aug 30, 2018 at 1:32 PM, Amit Kapila wrote: > On Wed, Aug 29, 2018 at 5:17 PM Magnus Hagander > wrote: > > > > On Wed, Aug 29, 2018 at 1:44 PM, Amit Kapila > wrote: > >> > >> On Wed, Aug 29, 2018 at 5:05 PM Magnus Hagander > wrote: > >> > > >> > On Wed, Aug 29, 2018 at 1:31 PM, Amit Ka

Re: pg_verify_checksums vs windows

2018-08-30 Thread Amit Kapila
On Wed, Aug 29, 2018 at 5:17 PM Magnus Hagander wrote: > > On Wed, Aug 29, 2018 at 1:44 PM, Amit Kapila wrote: >> >> On Wed, Aug 29, 2018 at 5:05 PM Magnus Hagander wrote: >> > >> > On Wed, Aug 29, 2018 at 1:31 PM, Amit Kapila >> > wrote: >> >> >> >> So, I think we need to open the file in bin

Re: pg_verify_checksums vs windows

2018-08-29 Thread Magnus Hagander
On Wed, Aug 29, 2018 at 1:44 PM, Amit Kapila wrote: > On Wed, Aug 29, 2018 at 5:05 PM Magnus Hagander > wrote: > > > > On Wed, Aug 29, 2018 at 1:31 PM, Amit Kapila > wrote: > >> > >> So, I think we need to open the file in binary mode as in other parts > >> of the code. The attached patch fixe

Re: pg_verify_checksums vs windows

2018-08-29 Thread Amit Kapila
On Wed, Aug 29, 2018 at 5:05 PM Magnus Hagander wrote: > > On Wed, Aug 29, 2018 at 1:31 PM, Amit Kapila wrote: >> >> So, I think we need to open the file in binary mode as in other parts >> of the code. The attached patch fixes the problem for me. >> >> Thoughts? > > > Yikes. Yes, I believe you

Re: pg_verify_checksums vs windows

2018-08-29 Thread Magnus Hagander
On Wed, Aug 29, 2018 at 1:31 PM, Amit Kapila wrote: > While trying to debug a recent bug report on hash indexes [1], I > noticed that pg_verify_checksums don't work on Windows (or at least in > my environment). > > initdb -k ..\..\data > pg_verify_checksums.exe ..\..\Data > pg_verify_checksums:

pg_verify_checksums vs windows

2018-08-29 Thread Amit Kapila
While trying to debug a recent bug report on hash indexes [1], I noticed that pg_verify_checksums don't work on Windows (or at least in my environment). initdb -k ..\..\data pg_verify_checksums.exe ..\..\Data pg_verify_checksums: short read of block 0 in file "..\..\Data/global/1136", got only 15