Re: pg_walinspect float4/float8 confusion

2022-09-12 Thread Peter Eisentraut
On 09.09.22 05:51, Bharath Rupireddy wrote: On Thu, Sep 8, 2022 at 5:23 PM Peter Eisentraut wrote: The pg_walinspect function pg_get_wal_stats() has output arguments declared as float4 (count_percentage, record_size_percentage, etc.), but the internal computations are all done in type double.

Re: pg_walinspect float4/float8 confusion

2022-09-08 Thread Bharath Rupireddy
On Thu, Sep 8, 2022 at 5:23 PM Peter Eisentraut wrote: > > The pg_walinspect function pg_get_wal_stats() has output arguments > declared as float4 (count_percentage, record_size_percentage, etc.), but > the internal computations are all done in type double. Is there a > reason why this is then co

pg_walinspect float4/float8 confusion

2022-09-08 Thread Peter Eisentraut
The pg_walinspect function pg_get_wal_stats() has output arguments declared as float4 (count_percentage, record_size_percentage, etc.), but the internal computations are all done in type double. Is there a reason why this is then converted to float4 for output? It probably doesn't matter in p