Re: pgbench - rework variable management

2020-09-19 Thread Fabien COELHO
Bonjour Michaël, https://www.postgresql.org/message-id/CAMN686ExUKturcWp4POaaVz3gR3hauSGBjOCd0E-Jh1zEXqf_Q%40mail.gmail.com Since then, the patch is failing to apply. As this got zero activity for the last six months, I am marking the entry as returned with feedback in the CF app. Hmmm… I

Re: pgbench - rework variable management

2020-09-16 Thread Michael Paquier
On Fri, Mar 27, 2020 at 06:42:49PM -0400, David Steele wrote: > Regarding Windows testing you may find this thread useful: > > https://www.postgresql.org/message-id/CAMN686ExUKturcWp4POaaVz3gR3hauSGBjOCd0E-Jh1zEXqf_Q%40mail.gmail.com Since then, the patch is failing to apply. As this got zero ac

Re: pgbench - rework variable management

2020-03-27 Thread David Steele
On 3/27/20 6:25 PM, Fabien COELHO wrote: Patch v5 is a rebase with some adjustements. This patch is failing on the Windows build: https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.85698 I'm not sure if this had been fixed in v3 and this is a new issue or if it has bee

Re: pgbench - rework variable management

2020-03-27 Thread Fabien COELHO
Patch v5 is a rebase with some adjustements. This patch is failing on the Windows build: https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.85698 I'm not sure if this had been fixed in v3 and this is a new issue or if it has been failing all along. Either way, it should b

Re: pgbench - rework variable management

2020-03-27 Thread David Steele
Hi Fabien, On 1/9/20 5:04 PM, Fabien COELHO wrote: Patch v4 is a just a rebase. Patch v5 is a rebase with some adjustements. This patch is failing on the Windows build: https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.85698 I'm not sure if this had been fixed in v3 an

Re: pgbench - rework variable management

2020-01-09 Thread Fabien COELHO
Patch v4 is a just a rebase. Patch v5 is a rebase with some adjustements. -- Fabien.diff --git a/src/bin/pgbench/Makefile b/src/bin/pgbench/Makefile index f402fe7b91..e1d3ef9bb3 100644 --- a/src/bin/pgbench/Makefile +++ b/src/bin/pgbench/Makefile @@ -10,6 +10,7 @@ include $(top_builddir)/src/

Re: pgbench - rework variable management

2019-11-06 Thread Fabien COELHO
Patch v4 is a just a rebase. -- Fabien.diff --git a/src/bin/pgbench/Makefile b/src/bin/pgbench/Makefile index f402fe7b91..e1d3ef9bb3 100644 --- a/src/bin/pgbench/Makefile +++ b/src/bin/pgbench/Makefile @@ -10,6 +10,7 @@ include $(top_builddir)/src/Makefile.global OBJS = \ $(WIN32RES) \ expr

Re: pgbench - rework variable management

2019-09-03 Thread Fabien COELHO
Hello Thomas, I noticed, but I do not have any windows host so I cannot test locally. The issue is how to do a mutex on Windows, which does not have pthread so it has to be emulated. I'll try again by sending a blind update to the patch and see how it goes. If you have the patience and a git

Re: pgbench - rework variable management

2019-09-02 Thread Thomas Munro
On Tue, Sep 3, 2019 at 4:57 PM Fabien COELHO wrote: > I noticed, but I do not have any windows host so I cannot test locally. > > The issue is how to do a mutex on Windows, which does not have pthread so > it has to be emulated. I'll try again by sending a blind update to the > patch and see how i

Re: pgbench - rework variable management

2019-09-02 Thread Fabien COELHO
Some windows-specific hacks are note tested. Somehow this macro hackery has upset the Windows socket headers: https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.55019 I noticed, but I do not have any windows host so I cannot test locally. The issue is how to do a mutex

Re: pgbench - rework variable management

2019-09-02 Thread Thomas Munro
On Wed, Aug 14, 2019 at 3:54 AM Fabien COELHO wrote: > Some windows-specific hacks are note tested. Somehow this macro hackery has upset the Windows socket headers: https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.55019 -- Thomas Munro https://enterprisedb.com

pgbench - rework variable management

2019-08-13 Thread Fabien COELHO
Hello pgdevs, The attached patch improves pgbench variable management as discussed in: https://www.postgresql.org/message-id/flat/alpine.DEB.2.21.1904081752210.5867@lancre As discussed there as well, the overall effect is small compared to libpq & system costs when pgbench is talking to a pos