Re: pgbench and timestamps (bounced)

2021-01-13 Thread Tom Lane
Fabien COELHO writes: >> What remains that we could do now, and perhaps back-patch, is point (2) >> i.e. disallow digits as the first character of a pgbench variable name. > I'm fine with that. >> That would be enough to "solve" the original bug report, and it does seem >> like it could be

Re: pgbench and timestamps (bounced)

2021-01-13 Thread Fabien COELHO
Hello Tom, Hi, this entry is "Waiting on Author" and the thread was inactive for a while. I see this discussion still has some open questions. Are you going to continue working on it, or should I mark it as "returned with feedback" until a better time? IMHO the proposed fix is reasonable

Re: pgbench and timestamps (bounced)

2021-01-12 Thread Tom Lane
Fabien COELHO writes: >> Hi, this entry is "Waiting on Author" and the thread was inactive for a >> while. I see this discussion still has some open questions. Are you >> going to continue working on it, or should I mark it as "returned with >> feedback" until a better time? > IMHO the

Re: pgbench and timestamps (bounced)

2020-11-26 Thread Fabien COELHO
CFM reminder. Hi, this entry is "Waiting on Author" and the thread was inactive for a while. I see this discussion still has some open questions. Are you going to continue working on it, or should I mark it as "returned with feedback" until a better time? IMHO the proposed fix is

Re: pgbench and timestamps (bounced)

2020-11-24 Thread Anastasia Lubennikova
On 11.09.2020 16:59, Fabien COELHO wrote: Hello Tom, It requires a mutex around the commands, I tried to do some windows implementation which may or may not work. Ugh, I'd really rather not do that.  Even disregarding the effects of a mutex, though, my initial idea for fixing this has a big

Re: pgbench and timestamps (bounced)

2020-09-11 Thread Fabien COELHO
Hello Tom, It requires a mutex around the commands, I tried to do some windows implementation which may or may not work. Ugh, I'd really rather not do that. Even disregarding the effects of a mutex, though, my initial idea for fixing this has a big problem: if we postpone PREPARE of the

Re: pgbench and timestamps (bounced)

2020-09-07 Thread Tom Lane
Fabien COELHO writes: > [Resent on hackers for CF registration, sorry for the noise] For the record, the original thread is at https://www.postgresql.org/message-id/flat/CAKVUGgQaZVAUi1Ex41H4wrru%3DFU%2BMfwgjG0aM1br6st7sz31Vw%40mail.gmail.com (I tried but failed to attach that thread to the CF

Re: pgbench and timestamps (bounced)

2020-07-09 Thread Fabien COELHO
Attached v2 fixes some errors, per cfbot. -- Fabien.diff --git a/doc/src/sgml/ref/pgbench.sgml b/doc/src/sgml/ref/pgbench.sgml index 9f3bb5fce6..9894ae9c04 100644 --- a/doc/src/sgml/ref/pgbench.sgml +++ b/doc/src/sgml/ref/pgbench.sgml @@ -998,15 +998,14 @@ pgbench options d There is a

Re: pgbench and timestamps (bounced)

2020-06-29 Thread Fabien COELHO
[Resent on hackers for CF registration, sorry for the noise] Hello Tom, The attached patch fixes some of the underlying problems reported by delaying the :var to $1 substitution to the last possible moments, so that what variables are actually defined is known. PREPARE-ing is also delayed to