Re: pgbench doc typos

2018-04-11 Thread Peter Eisentraut
On 3/30/18 03:30, Edmund Horner wrote: > On 30 March 2018 at 19:26, Fabien COELHO wrote: >> Thanks for the check. You might consider turning the patch as ready in the >> cf app. > > Ok, I have done so, since the patch is small and simple. > >>> Fixing the abs/hash

Re: pgbench doc typos

2018-03-30 Thread Edmund Horner
On 30 March 2018 at 19:26, Fabien COELHO wrote: > Thanks for the check. You might consider turning the patch as ready in the > cf app. Ok, I have done so, since the patch is small and simple. >> Fixing the abs/hash bracketing seems clear. The wasn't sure about >> rewriting

Re: pgbench doc typos

2018-03-30 Thread Fabien COELHO
Hello Edmund, Thanks for the check. You might consider turning the patch as ready in the cf app. Fixing the abs/hash bracketing seems clear. The wasn't sure about rewriting "mod(i, bj)" as "mod(i, j)", because there could be some convention about parameter names, but I can't think of

Re: pgbench doc typos

2018-03-29 Thread Edmund Horner
I did a quick review of this. The patch is just a doc typo fix and it applies cleanly to master (as of this email). I was able to build the docs, and they look ok. Fixing the abs/hash bracketing seems clear. The wasn't sure about rewriting "mod(i, bj)" as "mod(i, j)", because there could be

pgbench doc typos

2018-03-27 Thread Fabien COELHO
Attached patch fixes two very minor typos in pgbench recently added documentations: - one about the mod() function - two about the hash() function -- Fabien.diff --git a/doc/src/sgml/ref/pgbench.sgml b/doc/src/sgml/ref/pgbench.sgml index 41d9030..e4b37dd 100644 ---