Re: pgbench stopped supporting large number of client connections on Windows

2021-03-29 Thread David Steele
On 2/1/21 8:18 AM, Masahiko Sawada wrote: This patch on Commitfest has been "Waiting on Author" for almost 2 months. Could you share the current status? Are you updating the patch? Status update for a commitfest entry. Since this is a bug fix, I've moved this patch to the next commitfest. I t

Re: pgbench stopped supporting large number of client connections on Windows

2021-02-01 Thread Masahiko Sawada
Hi, On Thu, Jan 7, 2021 at 10:48 PM Masahiko Sawada wrote: > > Hi Marina, > > On Sun, Nov 8, 2020 at 11:59 PM Marina Polyakova > wrote: > > > > On 2020-11-07 01:01, Fabien COELHO wrote: > > > Hello Marina, > > > > Hello, Fabien! > > > > Thank you for your comments! > > > > >> While trying to te

Re: pgbench stopped supporting large number of client connections on Windows

2021-01-07 Thread Masahiko Sawada
Hi Marina, On Sun, Nov 8, 2020 at 11:59 PM Marina Polyakova wrote: > > On 2020-11-07 01:01, Fabien COELHO wrote: > > Hello Marina, > > Hello, Fabien! > > Thank you for your comments! > > >> While trying to test a patch that adds a synchronization barrier in > >> pgbench [1] on Windows, > > > > T

Re: pgbench stopped supporting large number of client connections on Windows

2020-11-08 Thread Marina Polyakova
On 2020-11-07 01:01, Fabien COELHO wrote: Hello Marina, Hello, Fabien! Thank you for your comments! While trying to test a patch that adds a synchronization barrier in pgbench [1] on Windows, Thanks for trying that, I do not have a windows setup for testing, and the sync code I wrote for W

Re: pgbench stopped supporting large number of client connections on Windows

2020-11-08 Thread Fabien COELHO
Hello Tom, Use ppoll, and start more threads but not too many? Does ppoll exist on Windows? Some g*gling suggest that the answer is no. There was a prior thread on this topic, which seems to have drifted off into the sunset: Indeed. I may have contributed to this dwindling by not adding

Re: pgbench stopped supporting large number of client connections on Windows

2020-11-07 Thread Ranier Vilela
Em sáb., 7 de nov. de 2020 às 14:55, Marina Polyakova < m.polyak...@postgrespro.ru> escreveu: > On 2020-11-06 23:54, Ranier Vilela wrote: > > Hi Marina, > > Hello! > > 1) If you mean the function pgwin32_select in the file > src/backend/port/win32/socket.c, IIUC it is only used in the backend, > s

Re: pgbench stopped supporting large number of client connections on Windows

2020-11-07 Thread Marina Polyakova
On 2020-11-06 23:54, Ranier Vilela wrote: Hi Marina, Hello! Nice catch. Thank you! rc/bin/pgbench/pgbench.c, the function add_socket_to_set: if (fd < 0 || fd >= FD_SETSIZE) { /* * Doing a hard exit here is a bit grotty, but it doesn't seem worth * complicating the API to make it less grot

Re: pgbench stopped supporting large number of client connections on Windows

2020-11-06 Thread Tom Lane
Fabien COELHO writes: >> Any suggestions are welcome! > Use ppoll, and start more threads but not too many? Does ppoll exist on Windows? There was a prior thread on this topic, which seems to have drifted off into the sunset: https://www.postgresql.org/message-id/flat/BL0PR1901MB1985F219C46C61

Re: pgbench stopped supporting large number of client connections on Windows

2020-11-06 Thread Fabien COELHO
Hello Marina, While trying to test a patch that adds a synchronization barrier in pgbench [1] on Windows, Thanks for trying that, I do not have a windows setup for testing, and the sync code I wrote for Windows is basically blind coding:-( I found that since the commit "Use ppoll(2), if a

re: pgbench stopped supporting large number of client connections on Windows

2020-11-06 Thread Ranier Vilela
Hi Marina, Nice catch. >rc/bin/pgbench/pgbench.c, the function add_socket_to_set: >if (fd < 0 || fd >= FD_SETSIZE) >{ >/* >* Doing a hard exit here is a bit grotty, but it doesn't seem worth >* complicating the API to make it less grotty. >*/ >pg_log_fatal("too many client connections for select()

pgbench stopped supporting large number of client connections on Windows

2020-11-06 Thread Marina Polyakova
Hello, hackers! While trying to test a patch that adds a synchronization barrier in pgbench [1] on Windows, I found that since the commit "Use ppoll(2), if available, to wait for input in pgbench." [2] I cannot use a large number of client connections in pgbench on my Windows virtual machines