Re: pgcrypto: Remove internal padding implementation

2022-03-22 Thread Peter Eisentraut
On 22.03.22 00:51, Nathan Bossart wrote: On Wed, Mar 16, 2022 at 11:12:06AM +0100, Peter Eisentraut wrote: Right, the previous behaviors were clearly faulty. I have updated the commit message to call out the behavior change more clearly. This patch is now complete from my perspective. I took

Re: pgcrypto: Remove internal padding implementation

2022-03-21 Thread Nathan Bossart
On Wed, Mar 16, 2022 at 11:12:06AM +0100, Peter Eisentraut wrote: > Right, the previous behaviors were clearly faulty. I have updated the > commit message to call out the behavior change more clearly. > > This patch is now complete from my perspective. I took a look at this patch and found nothi

Re: pgcrypto: Remove internal padding implementation

2022-03-16 Thread Peter Eisentraut
s now complete from my perspective.From 633d4aa0f762bf976e3ddc077cb9c34b58eeb4d5 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Wed, 16 Mar 2022 10:58:17 +0100 Subject: [PATCH v4] pgcrypto: Remove internal padding implementation Use the padding provided by OpenSSL instead of doing it ourse

Re: pgcrypto: Remove internal padding implementation

2022-02-22 Thread Jacob Champion
On Mon, 2022-02-21 at 11:42 +0100, Peter Eisentraut wrote: > On 15.02.22 00:07, Jacob Champion wrote: > > After this patch, bad padding is no longer ignored during decryption, > > and encryption without padding now requires the input size to be a > > multiple of the block size. To see the differenc

Re: pgcrypto: Remove internal padding implementation

2022-02-21 Thread Peter Eisentraut
eaning of the previous behaviors? Does bad padding even give correct answers on decryption? What does encryption without padding even do on incorrect input sizes?From 848289f7458d71742a327c1625c24a30981f9229 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Mon, 21 Feb 2022 11:24:27 +0100 S

Re: pgcrypto: Remove internal padding implementation

2022-02-14 Thread Jacob Champion
On Mon, 2022-02-14 at 10:42 +0100, Peter Eisentraut wrote: > This is a rebase of the patch from [0]. It removes the internal padding > implementation in pgcrypto and lets OpenSSL do it. The internal > implementation was once applicable to the non-OpenSSL code paths, but > those have since been

pgcrypto: Remove internal padding implementation

2022-02-14 Thread Peter Eisentraut
/b1a62889-bb45-e5e0-d138-7a370a0a3...@enterprisedb.comFrom 86e65690105e3a4a7e38276f48bd97c0e095beec Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Mon, 14 Feb 2022 10:32:48 +0100 Subject: [PATCH v2] pgcrypto: Remove internal padding implementation Use the padding provided by OpenSSL instead of