Re: pgindent fails with perl 5.40

2024-10-09 Thread Erik Wienhold
On 2024-10-09 09:52 +0200, Daniel Gustafsson wrote: > Done, thanks for the report! Thanks for pushing! -- Erik

Re: pgindent fails with perl 5.40

2024-10-09 Thread Daniel Gustafsson
> On 8 Oct 2024, at 22:56, Daniel Gustafsson wrote: > >> On 8 Oct 2024, at 22:24, Andrew Dunstan wrote: >> The patch looks fine, and should be backpatched. Looks like this is a 12 >> year old thinko. AFAICT File::Spec doesn't export anything. > > Thanks for confirming, I'll go do that in the

Re: pgindent fails with perl 5.40

2024-10-08 Thread Daniel Gustafsson
> On 8 Oct 2024, at 22:24, Andrew Dunstan wrote: > > On 2024-10-08 Tu 5:26 AM, Daniel Gustafsson wrote: >>> On 8 Oct 2024, at 03:50, Erik Wienhold wrote: Calling the import method of an unknown package produces a warning [...] It will also detect cases where a user passes an argum

Re: pgindent fails with perl 5.40

2024-10-08 Thread Andrew Dunstan
On 2024-10-08 Tu 5:26 AM, Daniel Gustafsson wrote: On 8 Oct 2024, at 03:50, Erik Wienhold wrote: Calling the import method of an unknown package produces a warning [...] It will also detect cases where a user passes an argument when using a package that does not provide its own import [...]

Re: pgindent fails with perl 5.40

2024-10-08 Thread Daniel Gustafsson
> On 8 Oct 2024, at 03:50, Erik Wienhold wrote: >> Calling the import method of an unknown package produces a warning >> [...] >> It will also detect cases where a user passes an argument when using a >> package that does not provide its own import >> [...] > > Because we use fatal warnings, pgi

Re: pgindent fails with perl 5.40

2024-10-07 Thread Erik Wienhold
I wrote: > I get this error when running pgindent with perl 5.40: > > Attempt to call undefined import method with arguments ("devnull") via > package "File::Spec" (Perhaps you forgot to load the package?) at > src/tools/pgindent/pgindent line 10. > BEGIN failed--compilation aborted at s

pgindent fails with perl 5.40

2024-10-07 Thread Erik Wienhold
I get this error when running pgindent with perl 5.40: Attempt to call undefined import method with arguments ("devnull") via package "File::Spec" (Perhaps you forgot to load the package?) at src/tools/pgindent/pgindent line 10. BEGIN failed--compilation aborted at src/tools/pgindent/pgi