On Mon, Feb 14, 2022 at 10:53:04AM +0900, Michael Paquier wrote:
> A last thing, that has been mentioned by Andres upthread, is that we
> should be able to remove the extra commands run with --version in the
> tests of pg_basebackup, as of the attached. I have not done that yet,
> as it seems
On Sun, Feb 13, 2022 at 11:13:51AM -0500, Robert Haas wrote:
> Well, that's because I didn't realize that LZ4 might be set to
> something that doesn't work at all. So Michael's thing worked, but
> because it (in my view) fixed the problem in a more surprising place
> than I would have preferred, I
On Sat, Feb 12, 2022 at 11:12:50PM -0500, Tom Lane wrote:
> Michael Paquier writes:
>> Well, this somebody is I, and the buildfarm did not blow up on any of
>> that so that looked rather fine.
>
> Eh? copperhead for one is failing for exactly this reason:
>
> Bailout called. Further testing
On Sat, Feb 12, 2022 at 11:12 PM Tom Lane wrote:
> Eh? copperhead for one is failing for exactly this reason:
>
> Bailout called. Further testing stopped: failed to execute command "lz4 -d
> -m
>
Michael Paquier writes:
> On Sat, Feb 12, 2022 at 05:16:03PM -0500, Tom Lane wrote:
>> I think adding an explicit PGAC_PATH_PROGS would be worth the cycles.
> Well, this somebody is I, and the buildfarm did not blow up on any of
> that so that looked rather fine.
Eh? copperhead for one is
On Sat, Feb 12, 2022 at 05:16:03PM -0500, Tom Lane wrote:
> It looks to me like somebody figured it didn't need any more support
> than gzip/bzip2, which is wrong on a couple of grounds:
> * hardly any modern platforms lack those, unlike lz4
> * we don't invoke either one of them during testing,
Robert Haas writes:
> On Sat, Feb 12, 2022 at 5:09 PM Andres Freund wrote:
>> I don't think there's an actual configure check for the lz4 binary? Looks
>> like
>> a static assignment in src/Makefile.global.in to me.
> Oh. That seems kind of dumb.
It looks to me like somebody figured it didn't
On Sat, Feb 12, 2022 at 5:09 PM Andres Freund wrote:
> On 2022-02-12 07:24:46 -0500, Robert Haas wrote:
> > You may be right, but I'm not entirely convinced. $ENV{'LZ4'} here is
> > being set by make, and make is setting it to whatever configure found.
> > If configure found a version of the lz4
On 2022-02-12 07:24:46 -0500, Robert Haas wrote:
> You may be right, but I'm not entirely convinced. $ENV{'LZ4'} here is
> being set by make, and make is setting it to whatever configure found.
> If configure found a version of the lz4 program that doesn't actually
> work, isn't that configure's
On Fri, Feb 11, 2022 at 11:39 PM Michael Paquier wrote:
> Perhaps you'd better check that 'decompress_program' can be executed
> and skip things if the command is not around? Note that
> 020_pg_receivewal.pl does an extra lz4 --version as a safety measure,
> but 008_untar.pl does not.
You may
10 matches
Mail list logo
