Re: pgsql: Clean up after TAP tests in oid2name and vacuumlo.

2018-09-05 Thread Michael Paquier
On Wed, Sep 05, 2018 at 01:05:42PM -0700, Michael Paquier wrote: > As far as I can see, the proposal is not cold to death and could have a > future, so I'll begin a new thread with a more complete patch. Done. Let's move the discussion here then: https://www.postgresql.org/message-id/201809060148

Re: pgsql: Clean up after TAP tests in oid2name and vacuumlo.

2018-09-05 Thread Michael Paquier
On Wed, Sep 05, 2018 at 03:20:03PM -0300, Alvaro Herrera wrote: > On 2018-Sep-05, Michael Paquier wrote: > > It would be better to start a new thread rather than posting > > a new patch, but I'd rather take the temperature first. > > Slightly feverish, it appears. As far as I can see, the proposa

Re: pgsql: Clean up after TAP tests in oid2name and vacuumlo.

2018-09-05 Thread Alvaro Herrera
On 2018-Sep-05, Michael Paquier wrote: > On Wed, Sep 05, 2018 at 11:39:50AM -0300, Alvaro Herrera wrote: > > Should this be used in src/test/modules/{brin,test_commit_ts} also? > > Hmm, I have not thought those two ones. commit_ts relies on REGRESS to > be defined so as it does its cleanup. bri

Re: pgsql: Clean up after TAP tests in oid2name and vacuumlo.

2018-09-05 Thread Tom Lane
Michael Paquier writes: > On Wed, Sep 05, 2018 at 11:39:50AM -0300, Alvaro Herrera wrote: >> Should this be used in src/test/modules/{brin,test_commit_ts} also? > Hmm, I have not thought those two ones. commit_ts relies on REGRESS to > be defined so as it does its cleanup. brin is more interest

Re: pgsql: Clean up after TAP tests in oid2name and vacuumlo.

2018-09-05 Thread Michael Paquier
On Wed, Sep 05, 2018 at 11:39:50AM -0300, Alvaro Herrera wrote: > Should this be used in src/test/modules/{brin,test_commit_ts} also? Hmm, I have not thought those two ones. commit_ts relies on REGRESS to be defined so as it does its cleanup. brin is more interesting, it directly quotes that it

Re: pgsql: Clean up after TAP tests in oid2name and vacuumlo.

2018-09-05 Thread Alvaro Herrera
On 2018-Sep-04, Michael Paquier wrote: > OK. I have dug into that, and finished with the attached. What do you > think? One thing is that the definition of submake is moving out of > REGRESS, and .PHONY gets defined. Should this be used in src/test/modules/{brin,test_commit_ts} also? Why do y