Re: pgsql: Removed unused variable, openLogOff.

2019-03-12 Thread Robert Haas
On Mon, Mar 11, 2019 at 10:23 PM Michael Paquier wrote: > On Mon, Mar 11, 2019 at 03:30:22PM -0400, Robert Haas wrote: > > Sorry that I didn't get to this before you did -- I was on PTO on > > Friday and did not work on the weekend. > > My apologies, Robert. It seems that I have been too much has

Re: pgsql: Removed unused variable, openLogOff.

2019-03-11 Thread Michael Paquier
On Mon, Mar 11, 2019 at 03:30:22PM -0400, Robert Haas wrote: > Sorry that I didn't get to this before you did -- I was on PTO on > Friday and did not work on the weekend. My apologies, Robert. It seems that I have been too much hasty then. There are so many things going around lately, it is hard

Re: pgsql: Removed unused variable, openLogOff.

2019-03-11 Thread Robert Haas
On Thu, Mar 7, 2019 at 8:27 PM Michael Paquier wrote: > After sleeping on it, let's live with just switching to nleft in the > message, without openLogOff as that's the second time folks complain > about the previous code. So I just propose the attached. Robert, > others, any objections? Perhap

Re: pgsql: Removed unused variable, openLogOff.

2019-03-10 Thread Michael Paquier
On Fri, Mar 08, 2019 at 10:27:52AM +0900, Michael Paquier wrote: > After sleeping on it, let's live with just switching to nleft in the > message, without openLogOff as that's the second time folks complain > about the previous code. So I just propose the attached. Robert, > others, any objection

Re: pgsql: Removed unused variable, openLogOff.

2019-03-07 Thread Michael Paquier
On Thu, Mar 07, 2019 at 11:11:16PM +0900, Michael Paquier wrote: > If you want to keep this formulation, that's fine for me. However you > should really change it to nleft as you suggest, and not keep nbytes. After sleeping on it, let's live with just switching to nleft in the message, without op

Re: pgsql: Removed unused variable, openLogOff.

2019-03-07 Thread Michael Paquier
On Thu, Mar 07, 2019 at 08:03:19AM -0500, Robert Haas wrote: > Oh, sorry, I didn't see the earlier thread. You're right that this is > messed up: if we're going to report startOffset rather than > openLogOff, we need to report nleft rather than bytes. I would prefer > to change nbytes -> nleft ra

Re: pgsql: Removed unused variable, openLogOff.

2019-03-07 Thread Robert Haas
On Wed, Mar 6, 2019 at 6:53 PM Michael Paquier wrote: > On Wed, Mar 06, 2019 at 02:47:16PM +, Robert Haas wrote: > > Removed unused variable, openLogOff. > > Is that right for the report if data is written in chunks? The same > patch has been proposed a couple of weeks ago, and I commented ab

Re: pgsql: Removed unused variable, openLogOff.

2019-03-06 Thread Michael Paquier
On Wed, Mar 06, 2019 at 02:47:16PM +, Robert Haas wrote: > Removed unused variable, openLogOff. Is that right for the report if data is written in chunks? The same patch has been proposed a couple of weeks ago, and I commented about it as follows: https://www.postgresql.org/message-id/2019012