Re: pgsql: psql: add an optional execution-count limit to \watch.

2024-04-27 Thread Andrew Dunstan
On 2023-04-07 Fr 10:00, Tom Lane wrote: Alexander Korotkov writes: On Thu, Apr 6, 2023 at 8:18 PM Tom Lane wrote: psql: add an optional execution-count limit to \watch. This commit makes tests fail for me. psql parses 'i' option of '\watch' using locale-aware strtod(), but 001_basic.pl

Re: pgsql: psql: add an optional execution-count limit to \watch.

2024-04-26 Thread Tom Lane
Anton Voloshin writes: > On 26/04/2024 17:38, Anton Voloshin wrote: >> I will try to report this to Perl community later. > Reported under https://github.com/Perl/perl5/issues/22176 Thanks for doing that. > Perl 5.36.3 seems to be fine (latest stable release before 5.38.x). > 5.38.0 and 5.38.2

Re: pgsql: psql: add an optional execution-count limit to \watch.

2024-04-26 Thread Anton Voloshin
On 26/04/2024 17:38, Anton Voloshin wrote: I will try to report this to Perl community later. Reported under https://github.com/Perl/perl5/issues/22176 Perl 5.36.3 seems to be fine (latest stable release before 5.38.x). 5.38.0 and 5.38.2 are broken. -- Anton Voloshin Postgres Professional,

Re: pgsql: psql: add an optional execution-count limit to \watch.

2024-04-26 Thread Anton Voloshin
On 26/04/2024 05:20, Tom Lane wrote: Haven't we worked around that everywhere it matters, in commits such as 8421f6bce and 605062227? Yes, needing 8421f6bce and 605062227 was, perhaps, surprising, but reasonable. Unlike breaking floating point constants in the source code. But, I guess,

Re: pgsql: psql: add an optional execution-count limit to \watch.

2024-04-25 Thread Tom Lane
Anton Voloshin writes: > On 18/04/2023 20:34, Tom Lane wrote (on pgsql-committers): >>> I shall now retire to a safe distance and watch the buildfarm. > Unfortunately, on fresh perl (5.38.2 verified) and on ru_RU.UTF-8 > locale, it breaks basic float comparison: 0 < 0.5 is no longer true.

Re: pgsql: psql: add an optional execution-count limit to \watch.

2024-04-25 Thread Anton Voloshin
Hello, hackers. On 18/04/2023 20:34, Tom Lane wrote (on pgsql-committers): > I shall now retire to a safe distance and watch the buildfarm. Unfortunately, on fresh perl (5.38.2 verified) and on ru_RU.UTF-8 locale, it breaks basic float comparison: 0 < 0.5 is no longer true. This is the