Re: postgres_fdw: oddity in costing presorted foreign scans with local stats

2019-06-14 Thread Etsuro Fujita
On Mon, Jun 10, 2019 at 5:37 PM Etsuro Fujita wrote: > On Thu, Jun 6, 2019 at 5:58 PM Etsuro Fujita wrote: > > I made stricter an assertion test I added on retrieved_rows. Also, I > > did some editorialization further and added the commit message. > > Attached is an updated version of the patch.

Re: postgres_fdw: oddity in costing presorted foreign scans with local stats

2019-06-10 Thread Etsuro Fujita
On Thu, Jun 6, 2019 at 5:58 PM Etsuro Fujita wrote: > I made stricter an assertion test I added on retrieved_rows. Also, I > did some editorialization further and added the commit message. > Attached is an updated version of the patch. If there are no > objections, I'll commit the patch. I noti

Re: postgres_fdw: oddity in costing presorted foreign scans with local stats

2019-06-06 Thread Etsuro Fujita
On Fri, May 17, 2019 at 8:31 PM Etsuro Fujita wrote: > I noticed that there is (another) oddity in commit aa09cd242f: in the > !fpinfo->use_remote_estimate mode, when first called for costing an > unsorted foreign scan, estimate_path_cost_size() computes > retrieved_rows, which is the estimated nu

postgres_fdw: oddity in costing presorted foreign scans with local stats

2019-05-17 Thread Etsuro Fujita
Hi, I noticed that there is (another) oddity in commit aa09cd242f: in the !fpinfo->use_remote_estimate mode, when first called for costing an unsorted foreign scan, estimate_path_cost_size() computes retrieved_rows, which is the estimated number of rows fetched from the remote server, by these: