Re: progress reporting for partitioned REINDEX

2021-02-19 Thread Justin Pryzby
On Sat, Feb 20, 2021 at 10:37:08AM +0900, Michael Paquier wrote: > > Also, I noticed that vacuum recurses into partition heirarchies since v10, > > but > > pg_stat_progress_vacuum also doesn't show anything about the parent table or > > the progress of recursing through the hierarchy. > > Yeah, t

Re: progress reporting for partitioned REINDEX

2021-02-19 Thread Michael Paquier
On Fri, Feb 19, 2021 at 12:12:54AM -0600, Justin Pryzby wrote: > Looks fine. Thanks, applied then to clarify things. > Also, I noticed that vacuum recurses into partition heirarchies since v10, but > pg_stat_progress_vacuum also doesn't show anything about the parent table or > the progress of re

Re: progress reporting for partitioned REINDEX

2021-02-18 Thread Justin Pryzby
On Fri, Feb 19, 2021 at 03:06:04PM +0900, Michael Paquier wrote: > On Thu, Feb 18, 2021 at 02:17:00PM +0900, Michael Paquier wrote: > > I have no issues with documenting more precisely on which commands > > partitions_total and partitions_done apply currently, by citing the > > commands where these

Re: progress reporting for partitioned REINDEX

2021-02-18 Thread Michael Paquier
On Thu, Feb 18, 2021 at 02:17:00PM +0900, Michael Paquier wrote: > I have no issues with documenting more precisely on which commands > partitions_total and partitions_done apply currently, by citing the > commands where these are effective. We do that for index_relid for > instance. Please find

Re: progress reporting for partitioned REINDEX

2021-02-17 Thread Michael Paquier
On Wed, Feb 17, 2021 at 10:24:37AM -0600, Justin Pryzby wrote: > When we implemented REINDEX of partitioned tables, it should've handled > progress reporting in the fields where that's reported for CREATE INDEX. > Or else we should document that "partitions_total/done are not populated for > REINDE

Re: progress reporting for partitioned REINDEX

2021-02-17 Thread Justin Pryzby
On Wed, Feb 17, 2021 at 03:36:20PM +0900, Michael Paquier wrote: > On Wed, Feb 17, 2021 at 12:10:43AM -0600, Justin Pryzby wrote: > > On Wed, Feb 17, 2021 at 02:55:04PM +0900, Michael Paquier wrote: > >> I see no bug here. > > > > pg_stat_progress_create_index includes partitions_{done,total} for

Re: progress reporting for partitioned REINDEX

2021-02-16 Thread Michael Paquier
On Wed, Feb 17, 2021 at 12:10:43AM -0600, Justin Pryzby wrote: > On Wed, Feb 17, 2021 at 02:55:04PM +0900, Michael Paquier wrote: >> I see no bug here. > > pg_stat_progress_create_index includes partitions_{done,total} for > CREATE INDEX p, so isn't it strange if it wouldn't do likewise for > REIN

Re: progress reporting for partitioned REINDEX

2021-02-16 Thread Justin Pryzby
On Wed, Feb 17, 2021 at 02:55:04PM +0900, Michael Paquier wrote: > I see no bug here. pg_stat_progress_create_index includes partitions_{done,total} for CREATE INDEX p, so isn't it strange if it wouldn't do likewise for REINDEX INDEX p ? -- Justin

Re: progress reporting for partitioned REINDEX

2021-02-16 Thread Michael Paquier
On Tue, Feb 16, 2021 at 12:39:08PM +0100, Matthias van de Meent wrote: > These were added to report the index and table that are currently > being worked on in concurrent reindexes of tables, schemas and > databases. Before that commit, it would only report up to the last > index being prepared in

Re: progress reporting for partitioned REINDEX

2021-02-16 Thread Matthias van de Meent
On Tue, 16 Feb 2021, 07:42 Justin Pryzby, wrote: > > It looks like we missed this in a6642b3ae. > > I think it's an odd behavior of pg_stat_progress_create_index to > simultaneously > show the global progress as well as the progress for the current partition ... > > It seems like for partitioned

progress reporting for partitioned REINDEX

2021-02-15 Thread Justin Pryzby
It looks like we missed this in a6642b3ae. I think it's an odd behavior of pg_stat_progress_create_index to simultaneously show the global progress as well as the progress for the current partition ... It seems like for partitioned reindex, reindex_index() should set the AM, which is used in the