Re: psql: Could we get "-- " prefixing on the **** QUERY **** outputs? (ECHO_HIDDEN)

2023-10-23 Thread Pavel Stehule
Hi út 24. 10. 2023 v 7:10 odesílatel Kirk Wolak napsal: > On Wed, Jul 26, 2023 at 5:39 PM Nathan Bossart > wrote: > >> On Wed, Jul 26, 2023 at 08:06:37AM +0200, Pavel Stehule wrote: >> > st 26. 7. 2023 v 6:22 odesílatel Nathan Bossart < >> nathandboss...@gmail.com> >> > napsal: >> >> Barring

Re: psql: Could we get "-- " prefixing on the **** QUERY **** outputs? (ECHO_HIDDEN)

2023-07-26 Thread Nathan Bossart
On Wed, Jul 26, 2023 at 02:39:25PM -0700, Nathan Bossart wrote: > Great. I spent some time on the commit message in v4. I plan to commit > this shortly. Committed. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com

Re: psql: Could we get "-- " prefixing on the **** QUERY **** outputs? (ECHO_HIDDEN)

2023-07-26 Thread Nathan Bossart
On Wed, Jul 26, 2023 at 08:06:37AM +0200, Pavel Stehule wrote: > st 26. 7. 2023 v 6:22 odesílatel Nathan Bossart > napsal: >> Barring additional feedback, I think this is ready for commit. >> >> > +1 Great. I spent some time on the commit message in v4. I plan to commit this shortly. --

Re: psql: Could we get "-- " prefixing on the **** QUERY **** outputs? (ECHO_HIDDEN)

2023-07-26 Thread Pavel Stehule
st 26. 7. 2023 v 6:22 odesílatel Nathan Bossart napsal: > I took a look at this patch and changed a couple things: > > * I made a similar adjustment to a few lines that seem to have been >missed. > * I removed a couple of asterisks from the adjusted lines in order to >maintain the

Re: psql: Could we get "-- " prefixing on the **** QUERY **** outputs? (ECHO_HIDDEN)

2023-07-25 Thread Nathan Bossart
I took a look at this patch and changed a couple things: * I made a similar adjustment to a few lines that seem to have been missed. * I removed a couple of asterisks from the adjusted lines in order to maintain the existing line lengths. Barring additional feedback, I think this is

Re: psql: Could we get "-- " prefixing on the **** QUERY **** outputs? (ECHO_HIDDEN)

2023-05-19 Thread Alvaro Herrera
On 2023-May-19, Andrey M. Borodin wrote: > I have a question, but mostly for my own knowledge. Translation > changes seem trivial for all languages, do we typically fix .po files > in such cases? Or do we leave it to translators to revise the stuff? The translations use a completely separate

Re: psql: Could we get "-- " prefixing on the **** QUERY **** outputs? (ECHO_HIDDEN)

2023-05-18 Thread Andrey M. Borodin
> On 18 May 2023, at 02:23, Kirk Wolak wrote: > > I labelled this v2. +1 to the feature and the patch looks good to me. I have a question, but mostly for my own knowledge. Translation changes seem trivial for all languages, do we typically fix .po files in such cases? Or do we leave it

Re: psql: Could we get "-- " prefixing on the **** QUERY **** outputs? (ECHO_HIDDEN)

2023-05-17 Thread Kirk Wolak
On Wed, May 17, 2023 at 2:13 PM Tom Lane wrote: > Laurenz Albe writes: > > You removed the QUERY at the end of the query. > > Fixed Also Fixed Pavel's name. Also Added Laurenze as a Reviewed By: (not sure, never want to NOT ack someone) > > Also, you'd have to avoid

Re: psql: Could we get "-- " prefixing on the **** QUERY **** outputs? (ECHO_HIDDEN)

2023-05-17 Thread Tom Lane
Laurenz Albe writes: > You removed the QUERY at the end of the query. > I think we should keep that (as comments, of course). People > are used to the current output, and it is nice to have a clear > visual marker at the end of what isn't normally part of "psql" > output. I

Re: psql: Could we get "-- " prefixing on the **** QUERY **** outputs? (ECHO_HIDDEN)

2023-05-17 Thread Laurenz Albe
On Wed, 2023-05-17 at 13:39 -0400, Kirk Wolak wrote: > Here's the patch. You removed the QUERY at the end of the query. I think we should keep that (as comments, of course). People are used to the current output, and it is nice to have a clear visual marker at the end of what

Re: psql: Could we get "-- " prefixing on the **** QUERY **** outputs? (ECHO_HIDDEN)

2023-05-17 Thread Kirk Wolak
On Mon, May 15, 2023 at 9:05 PM Kirk Wolak wrote: > On Mon, May 15, 2023 at 10:28 AM Tom Lane wrote: > >> Alvaro Herrera writes: >> > It's worth considering what will readline history do with the comment. >> > Hmmm... We could put a SPACE before the comment, that usually stops readline from

Re: psql: Could we get "-- " prefixing on the **** QUERY **** outputs? (ECHO_HIDDEN)

2023-05-15 Thread Kirk Wolak
On Mon, May 15, 2023 at 10:28 AM Tom Lane wrote: > Alvaro Herrera writes: > > It's worth considering what will readline history do with the comment. > > As I recall, we keep /* comments */ together with the query that > > follows, but the -- comments are keep in a separate history entry. > > So

Re: psql: Could we get "-- " prefixing on the **** QUERY **** outputs? (ECHO_HIDDEN)

2023-05-15 Thread Tom Lane
Alvaro Herrera writes: > It's worth considering what will readline history do with the comment. > As I recall, we keep /* comments */ together with the query that > follows, but the -- comments are keep in a separate history entry. > So that's one more reason to prefer /* */ Good point. > (To

Re: psql: Could we get "-- " prefixing on the **** QUERY **** outputs? (ECHO_HIDDEN)

2023-05-15 Thread Alvaro Herrera
On 2023-May-15, Tom Lane wrote: > Laurenz Albe writes: > > On Mon, 2023-05-15 at 08:37 +0200, Pavel Stehule wrote: > >> This looks little bit strange > >> > >> What about /* comments > >> Like > >> /*** Query / > >> Or just > >> Query > > > +1 for either of

Re: psql: Could we get "-- " prefixing on the **** QUERY **** outputs? (ECHO_HIDDEN)

2023-05-15 Thread Tom Lane
Laurenz Albe writes: > On Mon, 2023-05-15 at 08:37 +0200, Pavel Stehule wrote: >> This looks little bit strange >> >> What about /* comments >> Like >> /*** Query / >> Or just >> Query > +1 for either of Pavel's suggestions. +1. Probably the slash-star way would

Re: psql: Could we get "-- " prefixing on the **** QUERY **** outputs? (ECHO_HIDDEN)

2023-05-15 Thread Laurenz Albe
On Mon, 2023-05-15 at 08:37 +0200, Pavel Stehule wrote: > Dne po 15. 5. 2023 8:01 uživatel Kirk Wolak napsal: > > This would be a trivial change.  Willing to do it, and push it. > > > > In effect, we have this GREAT feature: > > \set ECHO_HIDDON on > > > > Which outputs a bunch of queries (as

Re: psql: Could we get "-- " prefixing on the **** QUERY **** outputs? (ECHO_HIDDEN)

2023-05-15 Thread Kirk Wolak
On Mon, May 15, 2023 at 2:37 AM Pavel Stehule wrote: > Hi > > Dne po 15. 5. 2023 8:01 uživatel Kirk Wolak napsal: > >> This would be a trivial change. Willing to do it, and push it. >> >> In effect, we have this GREAT feature: >> \set ECHO_HIDDON on >> -- ** >> >>

Re: psql: Could we get "-- " prefixing on the **** QUERY **** outputs? (ECHO_HIDDEN)

2023-05-15 Thread Pavel Stehule
Hi Dne po 15. 5. 2023 8:01 uživatel Kirk Wolak napsal: > This would be a trivial change. Willing to do it, and push it. > > In effect, we have this GREAT feature: > \set ECHO_HIDDON on > > Which outputs a bunch of queries (as you all know). > But somehow nobody thought that a user might want

psql: Could we get "-- " prefixing on the **** QUERY **** outputs? (ECHO_HIDDEN)

2023-05-15 Thread Kirk Wolak
This would be a trivial change. Willing to do it, and push it. In effect, we have this GREAT feature: \set ECHO_HIDDON on Which outputs a bunch of queries (as you all know). But somehow nobody thought that a user might want to paste ALL of the queries into their query editor, or even into