Re: psql UPDATE field [tab] expands to DEFAULT?

2019-06-25 Thread Tom Lane
I wrote: > I took a closer look and realized that this isn't some magic behavior of > arcane parts of libreadline; it's more like self-inflicted damage. It > happens because tab-complete.c's complete_from_const() is doing exactly > what its comment says it does: > /* > * This function returns

Re: psql UPDATE field [tab] expands to DEFAULT?

2019-06-20 Thread Tom Lane
I wrote: > Nosing around in tab-complete.c, I notice a fair number of other > places where we're doing COMPLETE_WITH() with just a single possible > completion. Knowing what we know now, in each one of those places > libreadline will suppose that that completion is the only syntactically > legal

Re: psql UPDATE field [tab] expands to DEFAULT?

2019-06-19 Thread Tom Lane
[ moving thread to -hackers ] So I propose the attached patch for fixing the clear bugs that have emerged in this discussion: don't confuse UPDATE ... SET ... with GUC-setting commands, and don't offer just DEFAULT in contexts where that's unlikely to be the only valid completion. Nosing around