Re: remove pg_class.relhaspkey

2018-03-14 Thread Michael Paquier
On Wed, Mar 14, 2018 at 03:36:28PM -0400, Peter Eisentraut wrote: > done Thanks Peter. One done, 150 remaining. -- Michael signature.asc Description: PGP signature

Re: remove pg_class.relhaspkey

2018-03-14 Thread Peter Eisentraut
On 3/14/18 01:47, Michael Paquier wrote: >> For the other flags we would probably need to test what impact would it >> have (e.g. table with no indexes, many indexes on other tables, and >> something calling get_relation_info a lot). But this patch proposes to >> remove only relhaspkey. > > Yes, y

Re: remove pg_class.relhaspkey

2018-03-13 Thread Michael Paquier
ass.h by the way. -- Michael From 1601b84f9ef2e8d0467b109c0b1d3df435edb59a Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Wed, 14 Mar 2018 14:46:43 +0900 Subject: [PATCH] Remove pg_class.relhaspkey It's not used for anything internally, and it can't be relied on for external uses

Re: remove pg_class.relhaspkey

2018-03-10 Thread Tomas Vondra
On 02/26/2018 07:23 AM, Michael Paquier wrote: > On Mon, Feb 26, 2018 at 12:45:48AM -0500, Tom Lane wrote: >> Michael Paquier writes: >>> On Sat, Feb 24, 2018 at 10:21:44PM -0500, Tom Lane wrote: We've discussed that at least twice before, and not pulled the trigger for fear of breakin

Re: remove pg_class.relhaspkey

2018-02-26 Thread Robert Haas
On Mon, Feb 26, 2018 at 12:36 AM, Michael Paquier wrote: > I would be of the opinion to drop them. +1. On this point, I am in agreement with the gentleman who wrote http://postgr.es/m/7903.1310671...@sss.pgh.pa.us -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreS

Re: remove pg_class.relhaspkey

2018-02-25 Thread Michael Paquier
On Mon, Feb 26, 2018 at 12:45:48AM -0500, Tom Lane wrote: > Michael Paquier writes: > > On Sat, Feb 24, 2018 at 10:21:44PM -0500, Tom Lane wrote: > >> We've discussed that at least twice before, and not pulled the trigger > >> for fear of breaking client code. > > > Speaking of which, I have look

Re: remove pg_class.relhaspkey

2018-02-25 Thread Tom Lane
Michael Paquier writes: > On Sat, Feb 24, 2018 at 10:21:44PM -0500, Tom Lane wrote: >> We've discussed that at least twice before, and not pulled the trigger >> for fear of breaking client code. > Speaking of which, I have looked at where relhaspkey is being used. And > there are a couple of thi

Re: remove pg_class.relhaspkey

2018-02-25 Thread Michael Paquier
On Sat, Feb 24, 2018 at 10:21:44PM -0500, Tom Lane wrote: > Peter Eisentraut writes: > > pg_class.relhaspkey doesn't seem to be used or useful for anything, so > > can we remove it? See attached patch. > > We've discussed that at least twice before, and not pulled the trigger > for fear of break

Re: remove pg_class.relhaspkey

2018-02-24 Thread Tom Lane
Peter Eisentraut writes: > pg_class.relhaspkey doesn't seem to be used or useful for anything, so > can we remove it? See attached patch. We've discussed that at least twice before, and not pulled the trigger for fear of breaking client code. https://www.postgresql.org/message-id/flat/CAA-aLv7s

remove pg_class.relhaspkey

2018-02-24 Thread Peter Eisentraut
e Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Sat, 24 Feb 2018 21:25:08 -0500 Subject: [PATCH] Remove pg_class.relhaspkey It's not used for anything internally, and it can't be relied on for external uses, so it can just be removed. --- doc/src/sgml/catalogs.sgml