BTW may I suggest that
git config diff.algorithm=histogram
results in better diffs?
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
This is looking attractive.
Please don't #include postgres.h in partcache.h. That's per policy.
Why do you need to #include parsenodes.h in partcache.h?
I think rewriteManip.h can do with just relcache.h rather than rel.h
(probably partition.h can do likewise)
thanks
--
Álvaro Herrera
On 2018/02/13 23:08, Ashutosh Bapat wrote:
> On Tue, Feb 13, 2018 at 2:17 PM, Amit Langote
> wrote:
>>
>> Agree with the proposed reorganizing and adding a partcache.c, which I
>> tried to do in the attached patch.
>>
>> * The new src/backend/utils/cache/partcache.c contains functions that
>> init
On Tue, Feb 13, 2018 at 2:17 PM, Amit Langote
wrote:
>
> Agree with the proposed reorganizing and adding a partcache.c, which I
> tried to do in the attached patch.
>
> * The new src/backend/utils/cache/partcache.c contains functions that
> initialize relcache's partitioning related fields. Vario
Thanks for working on this. May I suggest to open a completely new
thread?
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services