Re: replay of CREATE TABLESPACE eats data at wal_level=minimal

2021-09-03 Thread Robert Haas
On Thu, Sep 2, 2021 at 10:56 PM Noah Misch wrote: > > Is there anything still standing in the way of committing this? > > I pushed it as commit 97ddda8. Oh, thanks. Sorry, I had missed that. -- Robert Haas EDB: http://www.enterprisedb.com

Re: replay of CREATE TABLESPACE eats data at wal_level=minimal

2021-09-02 Thread Noah Misch
On Thu, Sep 02, 2021 at 11:28:27AM -0400, Robert Haas wrote: > On Wed, Aug 25, 2021 at 8:03 AM Robert Haas wrote: > > On Wed, Aug 25, 2021 at 1:21 AM Noah Misch wrote: > > > Sounds good. I think the log message is the optimal place: > > > > Looks awesome. > > Is there anything still standing

Re: replay of CREATE TABLESPACE eats data at wal_level=minimal

2021-09-02 Thread Robert Haas
On Wed, Aug 25, 2021 at 8:03 AM Robert Haas wrote: > On Wed, Aug 25, 2021 at 1:21 AM Noah Misch wrote: > > Sounds good. I think the log message is the optimal place: > > Looks awesome. Is there anything still standing in the way of committing this? -- Robert Haas EDB:

Re: replay of CREATE TABLESPACE eats data at wal_level=minimal

2021-08-25 Thread Robert Haas
On Wed, Aug 25, 2021 at 1:21 AM Noah Misch wrote: > Sounds good. I think the log message is the optimal place: Looks awesome. -- Robert Haas EDB: http://www.enterprisedb.com

Re: replay of CREATE TABLESPACE eats data at wal_level=minimal

2021-08-24 Thread Noah Misch
On Mon, Aug 23, 2021 at 09:08:44AM -0400, Robert Haas wrote: > On Sun, Aug 22, 2021 at 6:59 PM Noah Misch wrote: > > Here's what I plan to push. Besides adding a test, I modified things so > > CREATE TABLESPACE redo continues to report an error if a non-directory > > exists > > under the name

Re: replay of CREATE TABLESPACE eats data at wal_level=minimal

2021-08-23 Thread Robert Haas
On Sun, Aug 22, 2021 at 6:59 PM Noah Misch wrote: > Here's what I plan to push. Besides adding a test, I modified things so > CREATE TABLESPACE redo continues to report an error if a non-directory exists > under the name we seek to create. One could argue against covering that > corner case,

Re: replay of CREATE TABLESPACE eats data at wal_level=minimal

2021-08-23 Thread Prabhat Sahu
On Mon, Aug 23, 2021 at 4:29 AM Noah Misch wrote: > On Wed, Aug 18, 2021 at 10:32:10PM -0700, Noah Misch wrote: > > On Wed, Aug 18, 2021 at 10:47:24AM -0400, Robert Haas wrote: > > > On Tue, Aug 10, 2021 at 9:35 AM Robert Haas > wrote: > > > > Oh, yeah, I think that works, actually. I was

Re: replay of CREATE TABLESPACE eats data at wal_level=minimal

2021-08-22 Thread Noah Misch
On Wed, Aug 18, 2021 at 10:32:10PM -0700, Noah Misch wrote: > On Wed, Aug 18, 2021 at 10:47:24AM -0400, Robert Haas wrote: > > On Tue, Aug 10, 2021 at 9:35 AM Robert Haas wrote: > > > Oh, yeah, I think that works, actually. I was imagining a few problems > > > here, but I don't think they really

Re: replay of CREATE TABLESPACE eats data at wal_level=minimal

2021-08-18 Thread Noah Misch
On Wed, Aug 18, 2021 at 10:47:24AM -0400, Robert Haas wrote: > On Tue, Aug 10, 2021 at 9:35 AM Robert Haas wrote: > > Oh, yeah, I think that works, actually. I was imagining a few problems > > here, but I don't think they really exist. The redo routines for files > > within the directory can't

Re: replay of CREATE TABLESPACE eats data at wal_level=minimal

2021-08-18 Thread Robert Haas
On Tue, Aug 10, 2021 at 9:35 AM Robert Haas wrote: > Oh, yeah, I think that works, actually. I was imagining a few problems > here, but I don't think they really exist. The redo routines for files > within the directory can't possibly care about having the old files > erased for them, since that

Re: replay of CREATE TABLESPACE eats data at wal_level=minimal

2021-08-10 Thread Robert Haas
On Mon, Aug 9, 2021 at 9:23 PM Noah Misch wrote: > > I don't presently have a specific idea about how to fix this. > > Can't recovery just not delete the directory, create it if doesn't exist, and > be happy if it does exist? Like the attached WIP. If we think it's possible > for a crash during

Re: replay of CREATE TABLESPACE eats data at wal_level=minimal

2021-08-09 Thread Noah Misch
On Mon, Aug 09, 2021 at 01:08:42PM -0400, Robert Haas wrote: > To reproduce, initialize a cluster with wal_level=minimal and > max_wal_senders=0. Then from psql: > > \! mkdir /tmp/goose > > CHECKPOINT; > CREATE TABLESPACE goose LOCATION '/tmp/goose'; > SET wal_skip_threshold=0; > BEGIN; > CREATE

replay of CREATE TABLESPACE eats data at wal_level=minimal

2021-08-09 Thread Robert Haas
To reproduce, initialize a cluster with wal_level=minimal and max_wal_senders=0. Then from psql: \! mkdir /tmp/goose CHECKPOINT; CREATE TABLESPACE goose LOCATION '/tmp/goose'; SET wal_skip_threshold=0; BEGIN; CREATE TABLE wild (a int, b text) TABLESPACE goose; INSERT INTO wild VALUES (1,