Re: set TESTDIR from perl rather than Makefile

2022-02-25 Thread Justin Pryzby
On Sun, Feb 20, 2022 at 04:39:08PM -0800, Andres Freund wrote: > On 2022-02-19 17:53:09 -0600, Justin Pryzby wrote: > > I also meant to also attach it. > > Is the patch actually independent of the other patches in your stack? Yes - I rearranged it that way for this thread. However, it's best ser

Re: set TESTDIR from perl rather than Makefile

2022-02-25 Thread Andrew Dunstan
On 2/24/22 20:17, Justin Pryzby wrote: > On Mon, Feb 21, 2022 at 07:00:54AM -0500, Andrew Dunstan wrote: >> On 2/19/22 18:53, Justin Pryzby wrote: >>> On Sat, Feb 19, 2022 at 05:41:49PM -0600, Justin Pryzby wrote: I rebased and fixed the check-guc script to work, made it work with vpath

Re: set TESTDIR from perl rather than Makefile

2022-02-24 Thread Justin Pryzby
On Mon, Feb 21, 2022 at 07:00:54AM -0500, Andrew Dunstan wrote: > On 2/19/22 18:53, Justin Pryzby wrote: > > On Sat, Feb 19, 2022 at 05:41:49PM -0600, Justin Pryzby wrote: > >> I rebased and fixed the check-guc script to work, made it work with vpath > >> builds, and cleaned it up some. > > I also

Re: set TESTDIR from perl rather than Makefile

2022-02-21 Thread Andrew Dunstan
On 2/19/22 18:53, Justin Pryzby wrote: > On Sat, Feb 19, 2022 at 05:41:49PM -0600, Justin Pryzby wrote: >> I rebased and fixed the check-guc script to work, made it work with vpath >> builds, and cleaned it up some. > I also meant to also attach it. This is going to break a bunch of stuff as wr

Re: set TESTDIR from perl rather than Makefile

2022-02-20 Thread Andres Freund
Hi, On 2022-02-19 17:53:09 -0600, Justin Pryzby wrote: > I also meant to also attach it. Is the patch actually independent of the other patches in your stack? I like this concept a lot: - I've had to use a wrapper around individual tap tests for meson, just to set the CWD etc. - Being able t

Re: set TESTDIR from perl rather than Makefile

2022-02-19 Thread Justin Pryzby
On Sat, Feb 19, 2022 at 05:41:49PM -0600, Justin Pryzby wrote: > I rebased and fixed the check-guc script to work, made it work with vpath > builds, and cleaned it up some. I also meant to also attach it. > This (and other) patches ran here. > https://github.com/justinpryzby/postgres/runs/5261323

set TESTDIR from perl rather than Makefile

2022-02-19 Thread Justin Pryzby
Forking: On Tue, Feb 15, 2022 at 10:42:09PM -0800, Andres Freund wrote: > >> I was thinking that we should make Utils.pm's INIT block responsible for > >> figuring out both the directory a test should run in and the log location, > >> instead having that in vcregress.pl and Makefile.global.in. Mo