Re: snprintf assert is broken by plpgsql #option dump

2018-10-04 Thread Pavel Stehule
čt 4. 10. 2018 v 23:57 odesílatel Tom Lane napsal: > I wrote: > > Pavel Stehule writes: > >> I found two parts > > > Thanks for the report, will push something. > > On closer look, I'm not sure that these are the only places that are > assuming that any PLpgSQL_variable struct has a refname. Wh

Re: snprintf assert is broken by plpgsql #option dump

2018-10-04 Thread Tom Lane
I wrote: > Pavel Stehule writes: >> I found two parts > Thanks for the report, will push something. On closer look, I'm not sure that these are the only places that are assuming that any PLpgSQL_variable struct has a refname. What seems like a safer answer is to make sure they all do, more or l

Re: snprintf assert is broken by plpgsql #option dump

2018-10-04 Thread Tom Lane
Pavel Stehule writes: > There are new assert > Assert(strvalue != NULL); > probably all refname usage inside plpgsql dump functions has problem with > it. This isn't so much a "new assert" as a modeling of the fact that some printf implementations dump core on a null string pointer, and have done

snprintf assert is broken by plpgsql #option dump

2018-10-04 Thread Pavel Stehule
Hi Today I had broken plpgsql_check tests aganst PostgreSQL 12. After command create or replace function ml_trg() returns trigger as $$ #option dump declare begin if TG_OP = 'INSERT' then if NEW.status_from IS NULL then begin -- performance issue only select status int