On Mon, Feb 5, 2024 at 2:42 AM Peter Smith wrote:
>
> On Sat, Feb 3, 2024 at 5:28 PM Amit Kapila wrote:
> >
> > On Thu, Feb 1, 2024 at 5:58 AM Peter Smith wrote:
> > >
> > > OK. Now using your suggested 2nd sentence:
> > >
> > > +# The subscription's running status and failover option should be
On Sat, Feb 3, 2024 at 5:28 PM Amit Kapila wrote:
>
> On Thu, Feb 1, 2024 at 5:58 AM Peter Smith wrote:
> >
> > OK. Now using your suggested 2nd sentence:
> >
> > +# The subscription's running status and failover option should be preserved
> > +# in the upgraded instance. So regress_sub1 should s
On Thu, Feb 1, 2024 at 5:58 AM Peter Smith wrote:
>
> OK. Now using your suggested 2nd sentence:
>
> +# The subscription's running status and failover option should be preserved
> +# in the upgraded instance. So regress_sub1 should still have
> subenabled,subfailover
> +# set to true, while regres
On Wed, Jan 31, 2024 at 7:48 PM Alvaro Herrera wrote:
>
> How about rewording it more extensively? It doesn't read great IMO.
> I would use something like
>
> # In the upgraded instance, the running status and failover option of the
> # subscription with the failover option should have been prese
How about rewording it more extensively? It doesn't read great IMO.
I would use something like
# In the upgraded instance, the running status and failover option of the
# subscription with the failover option should have been preserved; the other
# should not.
# So regress_sub1 should still have
On Wed, Jan 31, 2024 at 4:51 PM vignesh C wrote:
>
> On Wed, 31 Jan 2024 at 10:27, Peter Smith wrote:
> >
> > Hi,
> >
> > PSA a small fix for a misleading comment found in the pg_upgrade test code.
>
> Is the double # intentional here, as I did not see this style of
> commenting used elsewhere:
>
On Wed, 31 Jan 2024 at 10:27, Peter Smith wrote:
>
> Hi,
>
> PSA a small fix for a misleading comment found in the pg_upgrade test code.
Is the double # intentional here, as I did not see this style of
commenting used elsewhere:
+# # Upgraded regress_sub1 should still have enabled and failover as
Hi,
PSA a small fix for a misleading comment found in the pg_upgrade test code.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
v1-0001-Fix-test-comment.patch
Description: Binary data
