Re: src/include/utils/float.h comment one link stable

2025-10-18 Thread David Rowley
On Tue, 7 Oct 2025 at 02:11, Daniel Gustafsson wrote: > Judging by the cec8394b5ccd3 this was added for MSVC 2013 support, and commit > 8fd9bb1d9654c59d bumped the minimum requirement to MSVC 2019, so I wonder if > this at all relevant anymore? Looks like these were added in cec8394b5 for VS2013

Re: src/include/utils/float.h comment one link stable

2025-10-18 Thread Tom Lane
David Rowley writes: > On Tue, 7 Oct 2025 at 04:24, Tom Lane wrote: >> I wonder if we couldn't also remove the NAN hacks in the same file. >> NAN's been required since C99 as well, and it's equally hard to >> believe that we still need to support compilers that don't conform. >> >> (Strictly spe

Re: src/include/utils/float.h comment one link stable

2025-10-17 Thread Tom Lane
I wrote: > David Rowley writes: >> I'd be happy for someone else to >> continue. I'm a bit hesitant due to the "#if defined(NAN) && >> !(defined(__NetBSD__) && defined(__mips__))", which are systems I have >> little knowledge of. > Fair enough, I'll take responsibility for that bit. Might as wel

Re: src/include/utils/float.h comment one link stable

2025-10-17 Thread Chao Li
> > this link (http://support.microsoft.com/kb/120968/en-us) is stale. > > This seems a mirror: https://jeffpar.github.io/kbarchive/kb/120/Q120968/ Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

Re: src/include/utils/float.h comment one link stable

2025-10-17 Thread Tom Lane
David Rowley writes: > Going by the draft C11 standard in [3], on page 230 it looks like > INFINITY is always defined now, so maybe we can get rid of the other > code and just always "return (float4) INFINITY;"? I did try that with > VS2022 just to make sure and I don't get a warning. +1, let's g

Re: src/include/utils/float.h comment one link stable

2025-10-17 Thread David Rowley
On Tue, 7 Oct 2025 at 04:24, Tom Lane wrote: > > David Rowley writes: > > Going by the draft C11 standard in [3], on page 230 it looks like > > INFINITY is always defined now, so maybe we can get rid of the other > > code and just always "return (float4) INFINITY;"? I did try that with > > VS2022

src/include/utils/float.h comment one link stable

2025-10-17 Thread jian he
hi. src/include/utils/float.h /* * Routines to provide reasonably platform-independent handling of * infinity and NaN * * We assume that isinf() and isnan() are available and work per spec. * (On some platforms, we have to supply our own; see src/port.) However, * generating an Infinity or

Re: src/include/utils/float.h comment one link stable

2025-10-17 Thread Daniel Gustafsson
> On 6 Oct 2025, at 14:51, jian he wrote: > this link (http://support.microsoft.com/kb/120968/en-us) is stale. Judging by the cec8394b5ccd3 this was added for MSVC 2013 support, and commit 8fd9bb1d9654c59d bumped the minimum requirement to MSVC 2019, so I wonder if this at all relevant anymore?