Re: struct RelOptInfo member relid comments

2024-05-23 Thread Tom Lane
Ashutosh Bapat writes: > OJ is an outer join, AFAIU. OJ's have their own relids. If you are > wondering why not all joins - I think inner joins need not be tracked as > separated relations in parse tree, but OJ's need to be. An outer join is necessarily associated with explicit JOIN syntax in the

Re: struct RelOptInfo member relid comments

2024-05-23 Thread Ashutosh Bapat
On Fri, May 24, 2024 at 9:09 AM jian he wrote: > On Fri, May 24, 2024 at 11:14 AM Tom Lane wrote: > > > > jian he writes: > > > imho, the above comment is not very helpful. > > > we should say more about what kind of information relid says about a > base rel? > > > > "Relid" is defined at the v

Re: struct RelOptInfo member relid comments

2024-05-23 Thread jian he
On Fri, May 24, 2024 at 11:14 AM Tom Lane wrote: > > jian he writes: > > imho, the above comment is not very helpful. > > we should say more about what kind of information relid says about a base > > rel? > > "Relid" is defined at the very top of the file: > > /* > * Relids > * Se

Re: struct RelOptInfo member relid comments

2024-05-23 Thread Tom Lane
jian he writes: > imho, the above comment is not very helpful. > we should say more about what kind of information relid says about a base rel? "Relid" is defined at the very top of the file: /* * Relids * Set of relation identifiers (indexes into the rangetable). */ typedef Bitm

Re: struct RelOptInfo member relid comments

2024-05-23 Thread Tender Wang
jian he 于2024年5月24日周五 10:58写道: > hi > > typedef struct RelOptInfo > { > > /* > * information about a base rel (not set for join rels!) > */ > Index relid; > ... > } > > imho, the above comment is not very helpful. > we should say more about what kind of information relid says about a base >

struct RelOptInfo member relid comments

2024-05-23 Thread jian he
hi typedef struct RelOptInfo { /* * information about a base rel (not set for join rels!) */ Index relid; ... } imho, the above comment is not very helpful. we should say more about what kind of information relid says about a base rel? I don't know much about RelOptInfo, that's why I ask.