Re: subscription/t/010_truncate.pl failure on desmoxytes in REL_13_STABLE

2021-06-26 Thread Amit Kapila
On Fri, Jun 25, 2021 at 8:16 PM Tom Lane wrote: > > Amit Kapila writes: > > On Thu, Jun 24, 2021 at 11:25 PM Tom Lane wrote: > >> Checking the git history, this was fixed in f560209c6, which also > >> included some other mostly-cosmetic cleanup. I'm inclined to > >> propose back-patching that w

Re: subscription/t/010_truncate.pl failure on desmoxytes in REL_13_STABLE

2021-06-25 Thread Tom Lane
Amit Kapila writes: > On Thu, Jun 24, 2021 at 11:25 PM Tom Lane wrote: >> Checking the git history, this was fixed in f560209c6, which also >> included some other mostly-cosmetic cleanup. I'm inclined to >> propose back-patching that whole commit, rather than allowing the >> code in exec_replica

Re: subscription/t/010_truncate.pl failure on desmoxytes in REL_13_STABLE

2021-06-24 Thread Amit Kapila
On Thu, Jun 24, 2021 at 11:25 PM Tom Lane wrote: > > Amit Kapila writes: > > On Tue, Jun 22, 2021 at 6:54 PM Tom Lane wrote: > >> BTW, the reason that the walsender is still showing its "query" as > >> "SELECT pg_config..." is that pre-v14 versions don't update the > >> reported query for replic

Re: subscription/t/010_truncate.pl failure on desmoxytes in REL_13_STABLE

2021-06-24 Thread Tom Lane
Amit Kapila writes: > On Tue, Jun 22, 2021 at 6:54 PM Tom Lane wrote: >> BTW, the reason that the walsender is still showing its "query" as >> "SELECT pg_config..." is that pre-v14 versions don't update the >> reported query for replication commands, only plain-SQL commands. >> I recall that we f

Re: subscription/t/010_truncate.pl failure on desmoxytes in REL_13_STABLE

2021-06-22 Thread Amit Kapila
On Tue, Jun 22, 2021 at 6:54 PM Tom Lane wrote: > > Thomas Munro writes: > > On Tue, Jun 22, 2021 at 10:01 PM Amit Kapila > > wrote: > >> I see this report is from 16th June 2021 and the commit is on 18th > >> June 2021. So, I am hoping this should have been fixed but if we see > >> it again th

Re: subscription/t/010_truncate.pl failure on desmoxytes in REL_13_STABLE

2021-06-22 Thread Tom Lane
Thomas Munro writes: > On Tue, Jun 22, 2021 at 10:01 PM Amit Kapila wrote: >> I see this report is from 16th June 2021 and the commit is on 18th >> June 2021. So, I am hoping this should have been fixed but if we see >> it again then probably we need to investigate it further. > Ahh, that makes

Re: subscription/t/010_truncate.pl failure on desmoxytes in REL_13_STABLE

2021-06-22 Thread Thomas Munro
On Tue, Jun 22, 2021 at 10:01 PM Amit Kapila wrote: > On Tue, Jun 22, 2021 at 10:33 AM Thomas Munro wrote: > > While scanning for assertion failures on the build farm that don't > > appear to have been discussed, I found this[1] in > > 010_truncate_publisher.log on the 13 branch: > > > > TRAP: Fa

Re: subscription/t/010_truncate.pl failure on desmoxytes in REL_13_STABLE

2021-06-22 Thread Amit Kapila
On Tue, Jun 22, 2021 at 10:33 AM Thomas Munro wrote: > > While scanning for assertion failures on the build farm that don't > appear to have been discussed, I found this[1] in > 010_truncate_publisher.log on the 13 branch: > > TRAP: FailedAssertion("tupdesc->tdrefcount <= 0", File: > "/home/bf/bui

subscription/t/010_truncate.pl failure on desmoxytes in REL_13_STABLE

2021-06-21 Thread Thomas Munro
Hi, While scanning for assertion failures on the build farm that don't appear to have been discussed, I found this[1] in 010_truncate_publisher.log on the 13 branch: TRAP: FailedAssertion("tupdesc->tdrefcount <= 0", File: "/home/bf/build/buildfarm-desmoxytes/REL_13_STABLE/pgsql.build/../pgsql/src