Re: thread-safety: getpwuid_r()

2024-09-02 Thread Peter Eisentraut
On 26.08.24 19:54, Heikki Linnakangas wrote: On 26/08/2024 20:38, Peter Eisentraut wrote: On 24.08.24 15:55, Heikki Linnakangas wrote: Come to think of it, the pg_get_user_name() function is just a thin wrapper around getpwuid_r(). It doesn't provide a lot of value. Perhaps we should remove pg

Re: thread-safety: getpwuid_r()

2024-08-26 Thread Heikki Linnakangas
On 26/08/2024 20:38, Peter Eisentraut wrote: On 24.08.24 15:55, Heikki Linnakangas wrote: Come to think of it, the pg_get_user_name() function is just a thin wrapper around getpwuid_r(). It doesn't provide a lot of value. Perhaps we should remove pg_get_user_name() and pg_get_user_home_dir() a

Re: thread-safety: getpwuid_r()

2024-08-26 Thread Peter Eisentraut
On 24.08.24 15:55, Heikki Linnakangas wrote: Come to think of it, the pg_get_user_name() function is just a thin wrapper around getpwuid_r(). It doesn't provide a lot of value. Perhaps we should remove pg_get_user_name() and pg_get_user_home_dir() altogether and call getpwuid_r() directly. Ye

Re: thread-safety: getpwuid_r()

2024-08-24 Thread Heikki Linnakangas
On 24/08/2024 11:42, Peter Eisentraut wrote: Here is a patch to replace a getpwuid() call in the backend, for thread-safety. This is AFAICT the only call in the getpw*() family that needs to be dealt with. (There is also a getgrnam() call, but that is called very early in the postmaster, before

thread-safety: getpwuid_r()

2024-08-24 Thread Peter Eisentraut
backend use, so it's also nicer to use the same function for consistency. From 090c800afd6271885d345f72bbd1d3b535dd6886 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Sat, 24 Aug 2024 10:35:56 +0200 Subject: [PATCH] thread-safety: getpwuid_r() There was one getpwuid() call in the ba