Re: typcache.c typos

2018-09-02 Thread David Rowley
On 3 September 2018 at 10:24, Robert Haas wrote: > On Tue, Aug 28, 2018 at 9:39 AM, Tom Lane wrote: >> I don't see any typos here; it looks to me more like a difference of >> opinion about whether "information" is singular or plural. I don't >> really feel a need to change the existing wording.

Re: typcache.c typos

2018-09-02 Thread Robert Haas
On Tue, Aug 28, 2018 at 9:39 AM, Tom Lane wrote: >> Opps. I mistakenly attached the incorrect patch. The correct one is >> attached to this email. > > I don't see any typos here; it looks to me more like a difference of > opinion about whether "information" is singular or plural. I don't >

Re: typcache.c typos

2018-08-28 Thread Chapman Flack
On 08/28/18 09:21, Michael Paquier wrote: > On Tue, Aug 28, 2018 at 01:57:12PM +0900, Amit Langote wrote: >> - * The type cache exists to speed lookup of certain information about data >> [ ... ] >> + * The type cache exists to speedup lookups of certain data type information >> >> Sorry if I'm

Re: typcache.c typos

2018-08-28 Thread Tom Lane
David Rowley writes: > On 28 August 2018 at 16:40, David Rowley wrote: >> I've attached a patch to fix a typo in typcache.c. I ended up also >> rephrasing the sentence since "information about data types that is", >> almost made me also want to change "is" to "are", since "types" is >> plural.

Re: typcache.c typos

2018-08-28 Thread Michael Paquier
On Tue, Aug 28, 2018 at 01:57:12PM +0900, Amit Langote wrote: > On 2018/08/28 13:42, David Rowley wrote: >> On 28 August 2018 at 16:40, David Rowley >> wrote: >>> I've attached a patch to fix a typo in typcache.c. I ended up also >>> rephrasing the sentence since "information about data types

Re: typcache.c typos

2018-08-27 Thread Amit Langote
Hi, On 2018/08/28 13:42, David Rowley wrote: > On 28 August 2018 at 16:40, David Rowley wrote: >> I've attached a patch to fix a typo in typcache.c. I ended up also >> rephrasing the sentence since "information about data types that is", >> almost made me also want to change "is" to "are", since

Re: typcache.c typos

2018-08-27 Thread David Rowley
On 28 August 2018 at 16:40, David Rowley wrote: > I've attached a patch to fix a typo in typcache.c. I ended up also > rephrasing the sentence since "information about data types that is", > almost made me also want to change "is" to "are", since "types" is > plural. That would have been a

typcache.c typos

2018-08-27 Thread David Rowley
I've attached a patch to fix a typo in typcache.c. I ended up also rephrasing the sentence since "information about data types that is", almost made me also want to change "is" to "are", since "types" is plural. That would have been a mistake since it's talking about the information and not the