Re: docs: minor typo fix for "lower(anymultirange)"

2024-04-24 Thread Michael Paquier
On Thu, Apr 25, 2024 at 09:02:34AM +0800, Richard Guo wrote: > Good catch! I checked the descriptions for "upper(anymultirange)", > "lower(anyrange)" and "upper(anyrange)", and they are all correct. We > should fix this one. +1. -- Michael signature.asc Description: PGP signature

Re: docs: minor typo fix for "lower(anymultirange)"

2024-04-24 Thread Richard Guo
On Thu, Apr 25, 2024 at 8:40 AM Ian Lawrence Barwick wrote: > Hi > > Here: > > > https://www.postgresql.org/docs/current/functions-range.html#MULTIRANGE-FUNCTIONS-TABLE > > the description for "lower(anymultirange)": > > > (NULL if the multirange is empty has no lower bound). > > is missing "or"

docs: minor typo fix for "lower(anymultirange)"

2024-04-24 Thread Ian Lawrence Barwick
Hi Here: https://www.postgresql.org/docs/current/functions-range.html#MULTIRANGE-FUNCTIONS-TABLE the description for "lower(anymultirange)": > (NULL if the multirange is empty has no lower bound). is missing "or" and should be: > (NULL if the multirange is empty or has no lower bound).

Small typo fix in logical decoding example

2021-08-18 Thread Daniel Gustafsson
The attached fixes s/atleast/at least/ in the logical decoding examples section in the docs, will push in a bit. -- Daniel Gustafsson https://vmware.com/ logdec_example_typo.diff Description: Binary data

Re: typo fix in pgstat.c: "exits should be exists"

2021-04-05 Thread vignesh C
On Tue, Apr 6, 2021 at 10:41 AM Fujii Masao wrote: > > > > On 2021/04/06 13:57, vignesh C wrote: > > Hi, > > > > While reviewing replication statistics I found a small typo. Attached > > patch for a typo in: > > src/backend/postmaster/pgstat.c > > Thanks for the report and patch! Pushed. > Thanks

Re: typo fix in pgstat.c: "exits should be exists"

2021-04-05 Thread Fujii Masao
On 2021/04/06 13:57, vignesh C wrote: Hi, While reviewing replication statistics I found a small typo. Attached patch for a typo in: src/backend/postmaster/pgstat.c Thanks for the report and patch! Pushed. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Developme

typo fix in pgstat.c: "exits should be exists"

2021-04-05 Thread vignesh C
Hi, While reviewing replication statistics I found a small typo. Attached patch for a typo in: src/backend/postmaster/pgstat.c /* -* Check if the slot exits with the given name. It is possible that by +* Check if the slot exists with

Re: [PATCH] typo fix in collationcmds.c: "if they are distinct"

2021-04-04 Thread Michael Paquier
On Sun, Apr 04, 2021 at 03:49:35PM +0300, Anton Voloshin wrote: > just a quick patch for a single-letter typo in a comment > in src/backend/commands/collationcmds.c > ... Thanks, fixed. This came from 51e225d. -- Michael signature.asc Description: PGP signature

[PATCH] typo fix in collationcmds.c: "if they are distinct"

2021-04-04 Thread Anton Voloshin
Hello, just a quick patch for a single-letter typo in a comment in src/backend/commands/collationcmds.c ... * set of language+region combinations, whereas the latter only returns -* language+region combinations of they are distinct from the language's +* language+region combinations

Re: Quick doc typo fix

2019-06-10 Thread Guillaume Lelarge
Le dim. 9 juin 2019 à 04:27, Michael Paquier a écrit : > On Sat, Jun 08, 2019 at 04:23:55PM +0200, Guillaume Lelarge wrote: > > We might find more typos, but it will take time. Applying this patch now > > (if it fits you) is probably better. > > I can imagine that it is a daunting task... Ok, fo

Re: Quick doc typo fix

2019-06-08 Thread Michael Paquier
On Sat, Jun 08, 2019 at 04:23:55PM +0200, Guillaume Lelarge wrote: > We might find more typos, but it will take time. Applying this patch now > (if it fits you) is probably better. I can imagine that it is a daunting task... Ok, for now I have applied what you sent. Thanks! -- Michael signatur

Re: Quick doc typo fix

2019-06-08 Thread Guillaume Lelarge
Le sam. 8 juin 2019 à 15:44, Julien Rouhaud a écrit : > On Sat, Jun 8, 2019 at 3:33 PM Michael Paquier > wrote: > > > > Hi Guillaume, > > > > On Wed, May 29, 2019 at 08:28:59PM +0200, Guillaume Lelarge wrote: > > > Sure. > > > > I have noticed your message on the French list about the completion

Re: Quick doc typo fix

2019-06-08 Thread Julien Rouhaud
On Sat, Jun 8, 2019 at 3:33 PM Michael Paquier wrote: > > Hi Guillaume, > > On Wed, May 29, 2019 at 08:28:59PM +0200, Guillaume Lelarge wrote: > > Sure. > > I have noticed your message on the French list about the completion of > the traduction, and congrats for that, it is a huge amount of work.

Re: Quick doc typo fix

2019-06-08 Thread Michael Paquier
Hi Guillaume, On Wed, May 29, 2019 at 08:28:59PM +0200, Guillaume Lelarge wrote: > Sure. I have noticed your message on the French list about the completion of the traduction, and congrats for that, it is a huge amount of work. Did you find anything else after your last report? -- Michael signa

Re: Quick doc typo fix

2019-05-29 Thread Guillaume Lelarge
Le mer. 29 mai 2019 19:52, Michael Paquier a écrit : > On Wed, May 29, 2019 at 07:47:12PM +0200, Guillaume Lelarge wrote: > > Yeah, I still have quite a lot to process. That might be better to do it > > all in once. > > OK, thanks! Could you ping me on this thread once you think you are > done?

Re: Quick doc typo fix

2019-05-29 Thread Michael Paquier
On Wed, May 29, 2019 at 07:47:12PM +0200, Guillaume Lelarge wrote: > Yeah, I still have quite a lot to process. That might be better to do it > all in once. OK, thanks! Could you ping me on this thread once you think you are done? -- Michael signature.asc Description: PGP signature

Re: Quick doc typo fix

2019-05-29 Thread Guillaume Lelarge
Le mer. 29 mai 2019 19:45, Michael Paquier a écrit : > On Wed, May 29, 2019 at 05:30:33PM +0200, Guillaume Lelarge wrote: > > And here is another one. See patch attached. > > Are you still going through some parts of the documentation? Perhaps > you may notice something else? I am wondering if

Re: Quick doc typo fix

2019-05-29 Thread Michael Paquier
On Wed, May 29, 2019 at 05:30:33PM +0200, Guillaume Lelarge wrote: > And here is another one. See patch attached. Are you still going through some parts of the documentation? Perhaps you may notice something else? I am wondering if it would be better to wait a bit more so as we can group all iss

Re: Quick doc typo fix

2019-05-29 Thread Michael Paquier
On Tue, May 28, 2019 at 09:46:48PM +0200, Guillaume Lelarge wrote: > Hehe, that was the first thing I wrote :) but went with "table and index" > as it was also used a bit later in the chapter. Both are fine with me. Okay, done this way. Thanks for the report. -- Michael signature.asc Descriptio

Re: Quick doc typo fix

2019-05-29 Thread Guillaume Lelarge
Le mar. 28 mai 2019 à 21:46, Guillaume Lelarge a écrit : > Le mar. 28 mai 2019 à 21:28, Michael Paquier a > écrit : > >> On Tue, May 28, 2019 at 05:05:10PM +0200, Guillaume Lelarge wrote: >> > >> >> linkend="catalog-pg-am">pg_am >> > - index access methods >> > + table a

Re: Quick doc typo fix

2019-05-28 Thread Guillaume Lelarge
Le mar. 28 mai 2019 à 21:28, Michael Paquier a écrit : > On Tue, May 28, 2019 at 05:05:10PM +0200, Guillaume Lelarge wrote: > > > > linkend="catalog-pg-am">pg_am > > - index access methods > > + table and index access methods > > > > Perhaps we could just say "rela

Re: Quick doc typo fix

2019-05-28 Thread Michael Paquier
On Tue, May 28, 2019 at 05:05:10PM +0200, Guillaume Lelarge wrote: > > linkend="catalog-pg-am">pg_am > - index access methods > + table and index access methods > Perhaps we could just say "relation" here? That's the term used on the paragraph describing pg_am. --

Quick doc typo fix

2019-05-28 Thread Guillaume Lelarge
Issue found while translating the v12 manual. I also fixed something that was missing, as far as I understand it (first fix, the typo is the second fix). See patch attached. Thanks. -- Guillaume. diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml index 4c7e93892a..f81f3d4160

Re: Small typo fix on tableam documentation

2019-04-05 Thread Andres Freund
Hi, On 2019-04-05 16:26:16 +, Alexis Andrieu wrote: > I noticed a small typo (word 'the' is repeated twice) in the recent tableam > doc. > > The patch remove the typo in the doc ('/doc/src/sgml/tableam.sgml'). Thanks for noticing and reporting! It was already reported by Justin Pryzby. I'd

Small typo fix on tableam documentation

2019-04-05 Thread Alexis Andrieu
Hello, I noticed a small typo (word 'the' is repeated twice) in the recent tableam doc. The patch remove the typo in the doc ('/doc/src/sgml/tableam.sgml'). Regard, Alexis tableam-fix-doc.patch Description: tableam-fix-doc.patch

Re: typo fix

2018-11-19 Thread Amit Langote
On 2018/11/20 15:58, Tom Lane wrote: > Michael Paquier writes: >> On Tue, Nov 20, 2018 at 02:00:39PM +0900, Amit Langote wrote: >>> - * We also use EquivalenceClasses as the base structure for PathKeys, >>> letting >>> + * We also use EquivalenceClass as the base structure for PathKeys, letting >

Re: typo fix

2018-11-19 Thread Michael Paquier
On Tue, Nov 20, 2018 at 01:58:22AM -0500, Tom Lane wrote: > The reason that's not good is that it creates a singular-plural mismatch. > If you'd also changed "PathKeys" to "PathKey", it would still read OK, > though I don't think it's an improvement particularly. > > (Hm ... though arguably, "stru

Re: typo fix

2018-11-19 Thread Tom Lane
Michael Paquier writes: > On Tue, Nov 20, 2018 at 02:00:39PM +0900, Amit Langote wrote: >> - * We also use EquivalenceClasses as the base structure for PathKeys, >> letting >> + * We also use EquivalenceClass as the base structure for PathKeys, letting > ... But not that. The reason that's not

Re: typo fix

2018-11-19 Thread Amit Langote
Thank you for looking. On 2018/11/20 14:13, Michael Paquier wrote: > On Tue, Nov 20, 2018 at 02:00:39PM +0900, Amit Langote wrote: >> It seems to me that EquivalenceClass, the struct/type name, has been >> misspelled as 'EquivalenceClasses' a couple of times in the comment above >> its definition.

Re: typo fix

2018-11-19 Thread Michael Paquier
On Tue, Nov 20, 2018 at 02:00:39PM +0900, Amit Langote wrote: > It seems to me that EquivalenceClass, the struct/type name, has been > misspelled as 'EquivalenceClasses' a couple of times in the comment above > its definition. EquivalenceClasses stands for the plural of EquivalenceClass. So think

typo fix

2018-11-19 Thread Amit Langote
Hi, It seems to me that EquivalenceClass, the struct/type name, has been misspelled as 'EquivalenceClasses' a couple of times in the comment above its definition. Attached fixes that. Thanks, Amit diff --git a/src/include/nodes/relation.h b/src/include/nodes/relation.h index 6fd24203dd..a695012c