Re: vac_update_datfrozenxid will raise "wrong tuple length" if pg_database tuple contains toast attribute.

2023-01-19 Thread Arthur Nascimento
On Thu, 19 Jan 2023 at 14:10, Nathan Bossart wrote: > This was recently back-patched [0] [1] [2]. Oh, I see that now. Thanks! Sorry for the noise. -- Arthur Nascimento EDB

Re: vac_update_datfrozenxid will raise "wrong tuple length" if pg_database tuple contains toast attribute.

2023-01-19 Thread Nathan Bossart
On Thu, Jan 19, 2023 at 10:42:47AM -0300, Arthur Nascimento wrote: > Would it be possible to backport the patch to 12 and 13? This was recently back-patched [0] [1] [2]. [0] https://postgr.es/m/y70xnvbuwqsr2...@paquier.xyz [1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=c0ee694

Re: vac_update_datfrozenxid will raise "wrong tuple length" if pg_database tuple contains toast attribute.

2023-01-19 Thread Arthur Nascimento
Hi Michael, I got a customer case that matches this issue. The customer is on an old version of 12, but I see the patch only went into 14: On Tue, 8 Dec 2020 at 00:32, Michael Paquier wrote: > > Yes the attached patch looks good to me for PostgreSQL. Thanks Michael. > Okay, committed to HEAD the

Re: vac_update_datfrozenxid will raise "wrong tuple length" if pg_database tuple contains toast attribute.

2020-12-07 Thread Michael Paquier
On Mon, Nov 30, 2020 at 04:37:14PM -0800, Ashwin Agrawal wrote: > I am thinking if there is some way to assert this aspect, but seems no way. > So, yes, having at least a comment is good for now. Yeah, I have been thinking about this one without coming to a clear idea, but that would be nice. > Y

Re: vac_update_datfrozenxid will raise "wrong tuple length" if pg_database tuple contains toast attribute.

2020-11-30 Thread Ashwin Agrawal
On Sun, Nov 29, 2020 at 5:27 PM Michael Paquier wrote: > > One thing that strikes me as unwise is that we could run into similar > > problems with vac_update_relstats() in the future, and there have been > > recent talks about having more toast tables like for pg_class. That > > is not worth car

Re: vac_update_datfrozenxid will raise "wrong tuple length" if pg_database tuple contains toast attribute.

2020-11-29 Thread Michael Paquier
On Wed, Nov 25, 2020 at 04:12:15PM +0900, Michael Paquier wrote: > Yeah, we had better fix and I guess backpatch something here. That's > annoying. I have considered that over the weekend, and let's be conservative. pg_database has gained a toast table since 12, and before that we would just have

Re: vac_update_datfrozenxid will raise "wrong tuple length" if pg_database tuple contains toast attribute.

2020-11-24 Thread Michael Paquier
On Wed, Nov 18, 2020 at 06:32:51AM +, Junfeng Yang wrote: > A path is attached co auther by Ashwin Agrawal, the solution is to > fetch the pg_database tuple from disk instead of system cache if > needed. Yeah, we had better fix and I guess backpatch something here. That's annoying. +DROP DAT

Re: vac_update_datfrozenxid will raise "wrong tuple length" if pg_database tuple contains toast attribute.

2020-11-24 Thread Amit Kapila
On Tue, Nov 24, 2020 at 2:07 PM Junfeng Yang wrote: > > Hi hackers, > > Can anyone help to verify this? > I think one way to get feedback is to register this patch for the next commit fest (https://commitfest.postgresql.org/31/) -- With Regards, Amit Kapila.

回复: vac_update_datfrozenxid will raise "wrong tuple length" if pg_database tuple contains toast attribute.

2020-11-24 Thread Junfeng Yang
Hi hackers, Can anyone help to verify this?

vac_update_datfrozenxid will raise "wrong tuple length" if pg_database tuple contains toast attribute.

2020-11-18 Thread Junfeng Yang
Hi hackers, Recently, we encounter an issue that if the database grant too many roles that `datacl` toasted, vacuum freeze will fail with error "wrong tuple length". To reproduce the issue, please follow below steps: CREATE DATABASE vacuum_freeze_test; -- create helper function create or replac