Re: vacuum verbose detail logs are unclear; log at *start* of each stage; show allvisible/frozen/hintbits

2020-01-22 Thread Michael Paquier
On Wed, Jan 22, 2020 at 02:34:57PM +0900, Michael Paquier wrote: > Shouldn't the last part of the sentence be "we should mark it so" > instead of "we should so mark it"? I would rephrase the whole as > follows: > "If the all-visible page is all-frozen but not marked as such yet, > mark it as

Re: vacuum verbose detail logs are unclear; log at *start* of each stage; show allvisible/frozen/hintbits

2020-01-21 Thread Michael Paquier
On Tue, Jan 21, 2020 at 07:49:34AM -0600, Justin Pryzby wrote: > Rebased against 40d964ec997f64227bc0ff5e058dc4a5770a70a9 > I added to March CF https://commitfest.postgresql.org/27/2425/ Please be careful with the sets of patches sent to a thread, just to say that what you are sending is

Re: vacuum verbose detail logs are unclear; log at *start* of each stage; show allvisible/frozen/hintbits

2020-01-21 Thread Justin Pryzby
Rebased against 40d964ec997f64227bc0ff5e058dc4a5770a70a9 I added to March CF https://commitfest.postgresql.org/27/2425/ >From 83407b81dfc1ed2dfaa6f115dc6c4a276efb07fc Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Wed, 27 Nov 2019 20:07:10 -0600 Subject: [PATCH v2 1/6] Rename buf to avoid

Re: vacuum verbose detail logs are unclear; log at *start* of each stage; show allvisible/frozen/hintbits

2020-01-12 Thread Justin Pryzby
On Sun, Dec 29, 2019 at 01:15:24PM -0500, Jeff Janes wrote: > On Fri, Dec 20, 2019 at 12:11 PM Justin Pryzby wrote: > > > This is a usability complaint. If one knows enough about vacuum and/or > > logging, I'm sure there's no issue. > > > | 11 DEBUG: "t": found 999 removable, 999